Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1315513005: Get rid of unused member function toNormalizedRange() from FrameSelection and VisibleSelection class (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of unused member function toNormalizedRange() from FrameSelection and VisibleSelection classes This patch gets rid of unused member function |toNormalizedRange()| from |FrameSelection| and |VisibleSelection| classes with re-formatting an associated comment for improving code health. BUG=n/a TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201206

Patch Set 1 : 2015-08-26T11:07:51 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -12 lines) Patch
M Source/core/editing/FrameSelection.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/editing/VisibleSelection.h View 1 chunk +4 lines, -5 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-26 02:18:42 UTC) #2
yoichio
lgtm
5 years, 4 months ago (2015-08-26 03:10:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315513005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315513005/1
5 years, 4 months ago (2015-08-26 03:20:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/44669)
5 years, 4 months ago (2015-08-26 04:47:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315513005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315513005/1
5 years, 4 months ago (2015-08-26 05:12:52 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 06:46:12 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201206

Powered by Google App Engine
This is Rietveld 408576698