Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: Source/core/editing/VisibleSelection.h

Issue 1315513005: Get rid of unused member function toNormalizedRange() from FrameSelection and VisibleSelection class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-26T11:07:51 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/editing/FrameSelection.h ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 bool isDirectional() const { return m_isDirectional; } 148 bool isDirectional() const { return m_isDirectional; }
149 void setIsDirectional(bool isDirectional) { m_isDirectional = isDirectional; } 149 void setIsDirectional(bool isDirectional) { m_isDirectional = isDirectional; }
150 150
151 void appendTrailingWhitespace(); 151 void appendTrailingWhitespace();
152 152
153 bool expandUsingGranularity(TextGranularity); 153 bool expandUsingGranularity(TextGranularity);
154 bool expandUsingGranularityInComposedTree(TextGranularity); 154 bool expandUsingGranularityInComposedTree(TextGranularity);
155 155
156 bool intersectsNode(Node*) const; 156 bool intersectsNode(Node*) const;
157 157
158 // FIXME: Most callers probably don't want these functions, but 158 // TODO(yosin) Most callers probably don't want these functions, but
159 // are using them for historical reasons. toNormalizedRange and 159 // are using them for historical reasons. |toNormalizedEphemeralRange()|
160 // toNormalizedEphemeralRange contracts the range around text, and 160 // contracts the range around text, and moves the caret most backward
161 // moves the caret upstream before returning the range/positions. 161 // visually equivalent position before returning the range/positions.
162 PassRefPtrWillBeRawPtr<Range> toNormalizedRange() const;
163 EphemeralRange toNormalizedEphemeralRange() const; 162 EphemeralRange toNormalizedEphemeralRange() const;
164 static EphemeralRange normalizeRange(const EphemeralRange&); 163 static EphemeralRange normalizeRange(const EphemeralRange&);
165 static EphemeralRangeInComposedTree normalizeRange(const EphemeralRangeInCom posedTree&); 164 static EphemeralRangeInComposedTree normalizeRange(const EphemeralRangeInCom posedTree&);
166 165
167 Element* rootEditableElement() const; 166 Element* rootEditableElement() const;
168 bool isContentEditable() const; 167 bool isContentEditable() const;
169 bool hasEditableStyle() const; 168 bool hasEditableStyle() const;
170 bool isContentRichlyEditable() const; 169 bool isContentRichlyEditable() const;
171 // Returns a shadow tree node for legacy shadow trees, a child of the 170 // Returns a shadow tree node for legacy shadow trees, a child of the
172 // ShadowRoot node for new shadow trees, or 0 for non-shadow trees. 171 // ShadowRoot node for new shadow trees, or 0 for non-shadow trees.
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 260
262 } // namespace blink 261 } // namespace blink
263 262
264 #ifndef NDEBUG 263 #ifndef NDEBUG
265 // Outside the WebCore namespace for ease of invocation from gdb. 264 // Outside the WebCore namespace for ease of invocation from gdb.
266 void showTree(const blink::VisibleSelection&); 265 void showTree(const blink::VisibleSelection&);
267 void showTree(const blink::VisibleSelection*); 266 void showTree(const blink::VisibleSelection*);
268 #endif 267 #endif
269 268
270 #endif // VisibleSelection_h 269 #endif // VisibleSelection_h
OLDNEW
« no previous file with comments | « Source/core/editing/FrameSelection.h ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698