Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: Source/core/editing/FrameSelection.h

Issue 1315513005: Get rid of unused member function toNormalizedRange() from FrameSelection and VisibleSelection class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-26T11:07:51 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/editing/VisibleSelection.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 bool isCaret() const { return m_selection.isCaret(); } 162 bool isCaret() const { return m_selection.isCaret(); }
163 bool isRange() const { return m_selection.isRange(); } 163 bool isRange() const { return m_selection.isRange(); }
164 bool isCaretOrRange() const { return m_selection.isCaretOrRange(); } 164 bool isCaretOrRange() const { return m_selection.isCaretOrRange(); }
165 bool isInPasswordField() const; 165 bool isInPasswordField() const;
166 bool isDirectional() const { return m_selection.isDirectional(); } 166 bool isDirectional() const { return m_selection.isDirectional(); }
167 167
168 // If this FrameSelection has a logical range which is still valid, this fun ction return its clone. Otherwise, 168 // If this FrameSelection has a logical range which is still valid, this fun ction return its clone. Otherwise,
169 // the return value from underlying VisibleSelection's firstRange() is retur ned. 169 // the return value from underlying VisibleSelection's firstRange() is retur ned.
170 PassRefPtrWillBeRawPtr<Range> firstRange() const; 170 PassRefPtrWillBeRawPtr<Range> firstRange() const;
171 171
172 PassRefPtrWillBeRawPtr<Range> toNormalizedRange() const { return m_selection .toNormalizedRange(); }
173
174 void nodeWillBeRemoved(Node&); 172 void nodeWillBeRemoved(Node&);
175 void didUpdateCharacterData(CharacterData*, unsigned offset, unsigned oldLen gth, unsigned newLength); 173 void didUpdateCharacterData(CharacterData*, unsigned offset, unsigned oldLen gth, unsigned newLength);
176 void didMergeTextNodes(const Text& oldNode, unsigned offset); 174 void didMergeTextNodes(const Text& oldNode, unsigned offset);
177 void didSplitTextNode(const Text& oldNode); 175 void didSplitTextNode(const Text& oldNode);
178 176
179 void updateAppearance(ResetCaretBlinkOption = None); 177 void updateAppearance(ResetCaretBlinkOption = None);
180 void setCaretVisible(bool caretIsVisible) { setCaretVisibility(caretIsVisibl e ? Visible : Hidden); } 178 void setCaretVisible(bool caretIsVisible) { setCaretVisibility(caretIsVisibl e ? Visible : Hidden); }
181 bool isCaretBoundsDirty() const { return m_caretRectDirty; } 179 bool isCaretBoundsDirty() const { return m_caretRectDirty; }
182 void setCaretRectNeedsUpdate(); 180 void setCaretRectNeedsUpdate();
183 void scheduleVisualUpdate() const; 181 void scheduleVisualUpdate() const;
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
339 } 337 }
340 } // namespace blink 338 } // namespace blink
341 339
342 #ifndef NDEBUG 340 #ifndef NDEBUG
343 // Outside the WebCore namespace for ease of invocation from gdb. 341 // Outside the WebCore namespace for ease of invocation from gdb.
344 void showTree(const blink::FrameSelection&); 342 void showTree(const blink::FrameSelection&);
345 void showTree(const blink::FrameSelection*); 343 void showTree(const blink::FrameSelection*);
346 #endif 344 #endif
347 345
348 #endif // FrameSelection_h 346 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/VisibleSelection.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698