Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 1315373005: DevTools: remove most convenience wrappers from WI.TimelineModel.Record (Closed)

Created:
5 years, 3 months ago by caseq
Modified:
5 years, 3 months ago
Reviewers:
alph, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: remove most convenience wrappers from WI.TimelineModel.Record These were mostly for the convenience of layout tests, rarely used in the prod code. Let's keep TimelineModel.Record() a thin wrapper that just adds hierarchy to trace events and keep timeline-specific logic away from it, since it has to work for bare trace events most of the time. BUG= Committed: https://crrev.com/27e3e53b8921271d2a9ae30e172ee257999f883d git-svn-id: svn://svn.chromium.org/blink/trunk@202020 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -141 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 1 chunk +15 lines, -9 lines 1 comment Download
M LayoutTests/inspector/tracing/timeline-coalescing.html View 1 chunk +3 lines, -2 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-filtering.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-layout-reason.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-network-received-data.html View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/tracing/timeline-network-resource.html View 1 chunk +11 lines, -8 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-paint.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-parse-html-expected.txt View 2 chunks +2 lines, -0 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-timer-fired-from-eval-call-site.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineModel.js View 10 chunks +15 lines, -99 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePresentationModel.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineUIUtils.js View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
caseq
5 years, 3 months ago (2015-09-09 22:49:08 UTC) #2
yurys
lgtm https://codereview.chromium.org/1315373005/diff/1/LayoutTests/http/tests/inspector/timeline-test.js File LayoutTests/http/tests/inspector/timeline-test.js (right): https://codereview.chromium.org/1315373005/diff/1/LayoutTests/http/tests/inspector/timeline-test.js#newcode299 LayoutTests/http/tests/inspector/timeline-test.js:299: if (object[field] === null || object[field] === undefined) ...
5 years, 3 months ago (2015-09-10 00:10:16 UTC) #3
caseq
On 2015/09/10 00:10:16, yurys wrote: > lgtm > > https://codereview.chromium.org/1315373005/diff/1/LayoutTests/http/tests/inspector/timeline-test.js > File LayoutTests/http/tests/inspector/timeline-test.js (right): > ...
5 years, 3 months ago (2015-09-10 00:54:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315373005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315373005/1
5 years, 3 months ago (2015-09-10 00:54:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202020
5 years, 3 months ago (2015-09-10 03:26:37 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:06:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27e3e53b8921271d2a9ae30e172ee257999f883d

Powered by Google App Engine
This is Rietveld 408576698