LayoutTests/inspector/tracing/timeline-filtering.html - Issue 1315373005: DevTools: remove most convenience wrappers from WI.TimelineModel.Record

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/tracing/timeline-filtering.html

Issue 1315373005: DevTools: remove most convenience wrappers from WI.TimelineModel.Record (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/inspector/timeline-test.js ('K') | « LayoutTests/inspector/tracing/timeline-coalescing.html ('k') | LayoutTests/inspector/tracing/timeline-layout-reason.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/tracing/timeline-filtering.html

diff --git a/LayoutTests/inspector/tracing/timeline-filtering.html b/LayoutTests/inspector/tracing/timeline-filtering.html

index afd39c2b82a08ca59f5d543fb00b02bb92a530ff..681608b521a4689fe995aa539f3ab3570828873c 100644

--- a/LayoutTests/inspector/tracing/timeline-filtering.html

+++ b/LayoutTests/inspector/tracing/timeline-filtering.html

@@ -64,7 +64,7 @@ function test()

prefix.push(" ");

}

var mark = record.expandable() ? (record.collapsed() ? "+" : "-") : " ";

- InspectorTest.addResult(prefix.join("") + mark + record.record().data().message);

+ InspectorTest.addResult(prefix.join("") + mark + record.record().traceEvent().args["data"].message);

}

function dumpRecords()

@@ -87,7 +87,7 @@ function test()

var collapseList = {"bar04":true, "foo13": true};

for (var i = 0; i < records.length; ++i) {

var record = records[i];

- if (collapseList[record.record().data().message])

+ if (collapseList[record.record().traceEvent().args["data"].message])

record.setCollapsed(true);

}

model.invalidateFilteredRecords();