Source/devtools/front_end/timeline/TimelinePresentationModel.js - Issue 1315373005: DevTools: remove most convenience wrappers from WI.TimelineModel.Record

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelinePresentationModel.js

Issue 1315373005: DevTools: remove most convenience wrappers from WI.TimelineModel.Record (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/inspector/timeline-test.js ('K') | « Source/devtools/front_end/timeline/TimelinePanel.js ('k') | Source/devtools/front_end/timeline/TimelineUIUtils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelinePresentationModel.js

diff --git a/Source/devtools/front_end/timeline/TimelinePresentationModel.js b/Source/devtools/front_end/timeline/TimelinePresentationModel.js

index 7ee7c514add00cda9c821ef034ce6d3be92a5023..ca1597284be1b7ee3aeb1b3363da81f7cfde8390 100644

--- a/Source/devtools/front_end/timeline/TimelinePresentationModel.js

+++ b/Source/devtools/front_end/timeline/TimelinePresentationModel.js

@@ -477,7 +477,7 @@ WebInspector.TimelinePresentationModel.ActualRecord.prototype = {

selfTime: function()

{

- return this._record.selfTime();

+ return this._record.traceEvent().selfTime;

/**

@@ -495,7 +495,7 @@ WebInspector.TimelinePresentationModel.ActualRecord.prototype = {

hasWarnings: function()

{

- return !!this._record.warnings();

+ return !!this._record.traceEvent().warning;

__proto__: WebInspector.TimelinePresentationModel.Record.prototype