Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1315373003: Revert "Make RelativePath use abspath rather than realpath for the 'path' variable." (Closed)

Created:
5 years, 3 months ago by bradn
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
gyp-developer_googlegroups.com, lindleyf, Nico, titzer
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Revert "Make RelativePath use abspath rather than realpath for the 'path' variable." This reverts commit 121d89dfcd4f6ebe1c89524b3f9ca11ddd437e77. R=dpranke@chromium.org > Make RelativePath use abspath rather than realpath for the 'path' variable. > This allows gyp to work correctly in symlink-heavy environments. Basically, > this is because gyp paths need to be in a consistent tree, so we need to > compute a path to the target within the *stated* tree, even if it is not > the real underlying path to the target. The 'relative_path' variable does > need to be resolved using realpath, since gyp or the underlying build system > might cd to it before looking for the 'path' target. > > Also make Ninja's host configuration consult environment variables analogous > to those it previously had for the target configuration, and replace os.getenv > with os.environ.get for consistency. > > R=thakis@chromium.org BUG= Committed: https://chromium.googlesource.com/external/gyp/+/5d01a8cda53bfa23f1dcbe0c31c33aa30f50cf4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -103 lines) Patch
M pylib/gyp/common.py View 1 chunk +1 line, -1 line 0 comments Download
M pylib/gyp/generator/ninja.py View 3 chunks +2 lines, -7 lines 0 comments Download
D test/symlinks/gyptest-symlinks.py View 1 chunk +0 lines, -69 lines 0 comments Download
D test/symlinks/hello.c View 1 chunk +0 lines, -11 lines 0 comments Download
D test/symlinks/hello.gyp View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
bradn
5 years, 3 months ago (2015-09-04 19:39:11 UTC) #2
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-04 19:56:42 UTC) #3
bradn
Committed patchset #1 (id:1) manually as 5d01a8cda53bfa23f1dcbe0c31c33aa30f50cf4c (presubmit successful).
5 years, 3 months ago (2015-09-04 19:58:51 UTC) #4
kjellander_chromium
5 years, 3 months ago (2015-09-07 06:05:41 UTC) #5
Message was sent while issue was closed.
On 2015/09/04 19:58:51, bradn wrote:
> Committed patchset #1 (id:1) manually as
> 5d01a8cda53bfa23f1dcbe0c31c33aa30f50cf4c (presubmit successful).

I created a roll CL to pick this up in
https://codereview.chromium.org/1304983008

Powered by Google App Engine
This is Rietveld 408576698