Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 1304983008: Roll src/tools/gyp 2b17e0b26..5d01a8cda (Closed)

Created:
5 years, 3 months ago by kjellander_chromium
Modified:
5 years, 3 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, bradnelson
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/tools/gyp 2b17e0b26..5d01a8cda https://chromium.googlesource.com/external/gyp.git/+log/2b17e0b26a93e8c9758c23aec6c554da4ca8f0a9..5d01a8cda53bfa23f1dcbe0c31c33aa30f50cf4c To pick up the revert in https://chromium.googlesource.com/external/gyp/+/5d01a8cda53bfa23f1dcbe0c31c33aa30f50cf4c that breaks certain projects sharing the Chromium build toolchain. BUG= Committed: https://crrev.com/5482f563e441be7ab1cf59a02e3fd9e010e9535b Cr-Commit-Position: refs/heads/master@{#347609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
kjellander_chromium
This will unblock WebRTC from rolling forward.
5 years, 3 months ago (2015-09-07 06:06:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304983008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304983008/1
5 years, 3 months ago (2015-09-07 06:06:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-07 07:15:42 UTC) #6
phoglund_chromium
Ok, feels good it's just that one patch and nothing else. lgtm
5 years, 3 months ago (2015-09-07 07:50:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304983008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304983008/1
5 years, 3 months ago (2015-09-07 08:12:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-07 08:17:35 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-07 08:18:17 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5482f563e441be7ab1cf59a02e3fd9e010e9535b
Cr-Commit-Position: refs/heads/master@{#347609}

Powered by Google App Engine
This is Rietveld 408576698