pylib/gyp/common.py - Issue 1315373003: Revert "Make RelativePath use abspath rather than realpath for the 'path' variable."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/common.py

Issue 1315373003: Revert "Make RelativePath use abspath rather than realpath for the 'path' variable." (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/common.py

diff --git a/pylib/gyp/common.py b/pylib/gyp/common.py

index 5df650029c08b8c1dd08e73ea3ab7208b65c3d6a..b6875e43efcbc40a14eb6a258626455e7ed91054 100644

--- a/pylib/gyp/common.py

+++ b/pylib/gyp/common.py

@@ -137,7 +137,7 @@ def RelativePath(path, relative_to):

# relative_to.

# Convert to normalized (and therefore absolute paths).

- path = os.path.abspath(path)

+ path = os.path.realpath(path)

relative_to = os.path.realpath(relative_to)

# On Windows, we can't create a relative path to a different drive, so just

« no previous file with comments | « no previous file | pylib/gyp/generator/ninja.py » ('j') | no next file with comments »