Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1315113005: Background mode: delete redundant calls to Enable/Disable. (Closed)

Created:
5 years, 3 months ago by Michael van Ouwerkerk
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Background mode: delete redundant calls to Enable/Disable. After SetEnabled it is redundant to called EnableBackgroundMode or DisableBackgroundMode as that already happens indirectly via OnBackgroundModeEnabledPrefChange. BUG=402456 Committed: https://crrev.com/18c38c1699d8e00c3c3b8a94fe0f8b7f0928e3d1 Cr-Commit-Position: refs/heads/master@{#348887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M chrome/browser/background/background_mode_manager_unittest.cc View 5 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Michael van Ouwerkerk
Hi Drew, please take a look.
5 years, 3 months ago (2015-09-01 14:20:31 UTC) #2
Michael van Ouwerkerk
Drew: please take a look.
5 years, 3 months ago (2015-09-15 11:01:15 UTC) #3
Peter Beverloo
lgtm
5 years, 3 months ago (2015-09-15 13:24:03 UTC) #5
Andrew T Wilson (Slow)
lgtm
5 years, 3 months ago (2015-09-15 14:30:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315113005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315113005/1
5 years, 3 months ago (2015-09-15 14:34:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 14:56:12 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/18c38c1699d8e00c3c3b8a94fe0f8b7f0928e3d1 Cr-Commit-Position: refs/heads/master@{#348887}
5 years, 3 months ago (2015-09-15 14:56:48 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:44:59 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/18c38c1699d8e00c3c3b8a94fe0f8b7f0928e3d1
Cr-Commit-Position: refs/heads/master@{#348887}

Powered by Google App Engine
This is Rietveld 408576698