Background mode: delete redundant calls to Enable/Disable.

chrome/browser/background/background_mode_manager_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/test_simple_task_runner.h"
@@ skipping 345 matching lines @@
 
 // App installs while background mode is disabled should do nothing.
 TEST_F(BackgroundModeManagerTest, BackgroundAppInstallUninstallWhileDisabled) {
   AdvancedTestBackgroundModeManager manager(
       *command_line_, profile_manager_->profile_info_cache(), true);
   manager.RegisterProfile(profile_);
 
   // Turn off background mode (shouldn't explicitly disable launch-on-startup as
   // the app-count is zero and launch-on-startup shouldn't be considered on).
   manager.SetEnabled(false);
-  manager.DisableBackgroundMode();
   AssertBackgroundModeInactive(manager);
 
   // Status tray icons will not be created, launch on startup status will not
   // be modified.
   manager.OnBackgroundAppInstalled(NULL);
   manager.SetBackgroundAppCountForProfile(profile_, 1);
   manager.OnApplicationListChanged(profile_);
   AssertBackgroundModeInactive(manager);
 
   manager.SetBackgroundAppCountForProfile(profile_, 0);
   manager.OnApplicationListChanged(profile_);
   AssertBackgroundModeInactive(manager);
 
   // Re-enable background mode (shouldn't actually enable launch-on-startup as
   // the app-count is zero).
   manager.SetEnabled(true);
-  manager.EnableBackgroundMode();
   AssertBackgroundModeInactive(manager);
 }
 
 
 // App installs while disabled should do nothing until background mode is
 // enabled..
 TEST_F(BackgroundModeManagerTest, EnableAfterBackgroundAppInstall) {
   AdvancedTestBackgroundModeManager manager(
       *command_line_, profile_manager_->profile_info_cache(), true);
   manager.RegisterProfile(profile_);
 
   // Install app, should show status tray icon.
   EXPECT_CALL(manager, EnableLaunchOnStartup(true)).Times(Exactly(1));
   manager.OnBackgroundAppInstalled(NULL);
   // OnBackgroundAppInstalled does not actually add an app to the
   // BackgroundApplicationListModel which would result in another
   // call to CreateStatusTray.
   manager.SetBackgroundAppCountForProfile(profile_, 1);
   manager.OnApplicationListChanged(profile_);
   AssertBackgroundModeActive(manager);
   Mock::VerifyAndClearExpectations(&manager);
 
   // Turn off background mode - should hide status tray icon.
   EXPECT_CALL(manager, EnableLaunchOnStartup(false)).Times(Exactly(1));
   manager.SetEnabled(false);
-  manager.DisableBackgroundMode();
   Mock::VerifyAndClearExpectations(&manager);
   AssertBackgroundModeInactive(manager);
 
   // Turn back on background mode - again, no status tray icon
   // will show up since we didn't actually add anything to the list.
   EXPECT_CALL(manager, EnableLaunchOnStartup(true)).Times(Exactly(1));
   manager.SetEnabled(true);
-  manager.EnableBackgroundMode();
   Mock::VerifyAndClearExpectations(&manager);
   AssertBackgroundModeActive(manager);
 
   // Uninstall app, should hide status tray icon again.
   EXPECT_CALL(manager, EnableLaunchOnStartup(false)).Times(Exactly(1));
   manager.SetBackgroundAppCountForProfile(profile_, 0);
   manager.OnApplicationListChanged(profile_);
   Mock::VerifyAndClearExpectations(&manager);
   AssertBackgroundModeInactive(manager);
 }
@@ skipping 16 matching lines @@
 
   // Install app for other profile, should show other status tray icon.
   manager.OnBackgroundAppInstalled(NULL);
   manager.SetBackgroundAppCountForProfile(profile2, 2);
   manager.OnApplicationListChanged(profile2);
   AssertBackgroundModeActive(manager);
 
   // Should hide both status tray icons.
   EXPECT_CALL(manager, EnableLaunchOnStartup(false)).Times(Exactly(1));
   manager.SetEnabled(false);
-  manager.DisableBackgroundMode();
   Mock::VerifyAndClearExpectations(&manager);
   AssertBackgroundModeInactive(manager);
 
   // Turn back on background mode - should show both status tray icons.
   EXPECT_CALL(manager, EnableLaunchOnStartup(true)).Times(Exactly(1));
   manager.SetEnabled(true);
-  manager.EnableBackgroundMode();
   Mock::VerifyAndClearExpectations(&manager);
   AssertBackgroundModeActive(manager);
 
   manager.SetBackgroundAppCountForProfile(profile_, 0);
   manager.OnApplicationListChanged(profile_);
   manager.SetBackgroundAppCountForProfile(profile2, 1);
   manager.OnApplicationListChanged(profile2);
   // There is still one background app alive
   AssertBackgroundModeActive(manager);
   // Verify the implicit expectations of no calls on this StrictMock.
@@ skipping 455 matching lines @@
   }
   service->AddExtension(upgraded_bg_ext.get());
   Mock::VerifyAndClearExpectations(manager_.get());
   EXPECT_FALSE(manager_->HasShownBalloon());
 
   // Upgrading an extension that didn't have background to one that does should
   // show the balloon.
   service->AddExtension(upgraded_no_bg_ext_has_bg.get());
   EXPECT_TRUE(manager_->HasShownBalloon());
 }