Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1308)

Unified Diff: chrome/browser/background/background_mode_manager_unittest.cc

Issue 1315113005: Background mode: delete redundant calls to Enable/Disable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/background/background_mode_manager_unittest.cc
diff --git a/chrome/browser/background/background_mode_manager_unittest.cc b/chrome/browser/background/background_mode_manager_unittest.cc
index 8551a7d4603543b5496fc389003cca84b1932f88..f08d2362ee8bd3579bfcfc8b3574fdd0fb60f12a 100644
--- a/chrome/browser/background/background_mode_manager_unittest.cc
+++ b/chrome/browser/background/background_mode_manager_unittest.cc
@@ -363,7 +363,6 @@ TEST_F(BackgroundModeManagerTest, BackgroundAppInstallUninstallWhileDisabled) {
// Turn off background mode (shouldn't explicitly disable launch-on-startup as
// the app-count is zero and launch-on-startup shouldn't be considered on).
manager.SetEnabled(false);
- manager.DisableBackgroundMode();
AssertBackgroundModeInactive(manager);
// Status tray icons will not be created, launch on startup status will not
@@ -380,7 +379,6 @@ TEST_F(BackgroundModeManagerTest, BackgroundAppInstallUninstallWhileDisabled) {
// Re-enable background mode (shouldn't actually enable launch-on-startup as
// the app-count is zero).
manager.SetEnabled(true);
- manager.EnableBackgroundMode();
AssertBackgroundModeInactive(manager);
}
@@ -406,7 +404,6 @@ TEST_F(BackgroundModeManagerTest, EnableAfterBackgroundAppInstall) {
// Turn off background mode - should hide status tray icon.
EXPECT_CALL(manager, EnableLaunchOnStartup(false)).Times(Exactly(1));
manager.SetEnabled(false);
- manager.DisableBackgroundMode();
Mock::VerifyAndClearExpectations(&manager);
AssertBackgroundModeInactive(manager);
@@ -414,7 +411,6 @@ TEST_F(BackgroundModeManagerTest, EnableAfterBackgroundAppInstall) {
// will show up since we didn't actually add anything to the list.
EXPECT_CALL(manager, EnableLaunchOnStartup(true)).Times(Exactly(1));
manager.SetEnabled(true);
- manager.EnableBackgroundMode();
Mock::VerifyAndClearExpectations(&manager);
AssertBackgroundModeActive(manager);
@@ -451,14 +447,12 @@ TEST_F(BackgroundModeManagerTest, MultiProfile) {
// Should hide both status tray icons.
EXPECT_CALL(manager, EnableLaunchOnStartup(false)).Times(Exactly(1));
manager.SetEnabled(false);
- manager.DisableBackgroundMode();
Mock::VerifyAndClearExpectations(&manager);
AssertBackgroundModeInactive(manager);
// Turn back on background mode - should show both status tray icons.
EXPECT_CALL(manager, EnableLaunchOnStartup(true)).Times(Exactly(1));
manager.SetEnabled(true);
- manager.EnableBackgroundMode();
Mock::VerifyAndClearExpectations(&manager);
AssertBackgroundModeActive(manager);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698