Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: cc/test/layer_test_common.cc

Issue 1314943008: cc: Remove implicit conversions from Rect to RectF in src/cc/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/layer_test_common.cc
diff --git a/cc/test/layer_test_common.cc b/cc/test/layer_test_common.cc
index 3517490f6c85365e922b28f0530ee99a21bd75c9..7cb97cd51bc41e78f0d754886d67204728239cca 100644
--- a/cc/test/layer_test_common.cc
+++ b/cc/test/layer_test_common.cc
@@ -84,10 +84,11 @@ void LayerTestCommon::VerifyQuadsAreOccluded(const QuadList& quads,
.IsPositiveScaleOrTranslation())
<< quad->shared_quad_state->quad_to_target_transform.ToString();
gfx::RectF target_rectf = MathUtil::MapClippedRect(
- quad->shared_quad_state->quad_to_target_transform, quad->rect);
+ quad->shared_quad_state->quad_to_target_transform,
+ gfx::RectF(quad->rect));
// Scale transforms allowed, as long as the final transformed rect
// ends up on integer boundaries for ease of testing.
- DCHECK_EQ(target_rectf.ToString(), gfx::RectF(target_rect).ToString());
+ ASSERT_EQ(target_rectf, gfx::RectF(target_rect));
vmpstr 2015/08/29 00:02:46 Why assert?
danakj 2015/08/29 00:13:37 Cuz then we don't need to ToString(). And it was a
vmpstr 2015/08/31 20:08:38 Ohh I thought this was EXPECT -> ASSERT change, no
}
gfx::Rect target_visible_rect = MathUtil::MapEnclosingClippedRect(
quad->shared_quad_state->quad_to_target_transform, quad->visible_rect);

Powered by Google App Engine
This is Rietveld 408576698