cc/tiles/picture_layer_tiling.cc - Issue 1314943008: cc: Remove implicit conversions from Rect to RectF in src/cc/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/tiles/picture_layer_tiling.cc

Issue 1314943008: cc: Remove implicit conversions from Rect to RectF in src/cc/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/tiles/picture_layer_tiling.cc

diff --git a/cc/tiles/picture_layer_tiling.cc b/cc/tiles/picture_layer_tiling.cc

index 5bef3aa22b5d1784f27801d5b05c410b2b4a831f..3bb2331722ad337e2fd1a7128d50f97ba76c7255 100644

--- a/cc/tiles/picture_layer_tiling.cc

+++ b/cc/tiles/picture_layer_tiling.cc

@@ -538,7 +538,7 @@ gfx::RectF PictureLayerTiling::CoverageIterator::texture_rect() const {

gfx::RectF texture_rect(current_geometry_rect_);

texture_rect.Scale(dest_to_content_scale_,

dest_to_content_scale_);

- texture_rect.Intersect(gfx::Rect(tiling_->tiling_size()));

+ texture_rect.Intersect(gfx::RectF(gfx::Rect(tiling_->tiling_size())));

vmpstr 2015/08/29 00:02:46 gfx::SizeF instead of gfx::Rect maybe?

danakj 2015/08/29 00:13:37 Done.

if (texture_rect.IsEmpty())

return texture_rect;

texture_rect.Offset(-tex_origin.OffsetFromOrigin());

« cc/test/layer_test_common.cc ('K') | « cc/test/layer_test_common.cc ('k') | cc/tiles/picture_layer_tiling_unittest.cc » ('j') | no next file with comments »