Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(625)

Issue 1314843002: Visit additional AST nodes as expressions in AstExpressionVisitor . (Closed)

Created:
5 years, 4 months ago by bradn
Modified:
5 years, 4 months ago
Reviewers:
titzer, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Visit additional AST nodes as expressions in AstExpressionVisitor . Visit AST Property nodes as expressions in AstExpressionVisitor. Visit Yield and Throw as they are expressions too. BUG= https://code.google.com/p/v8/issues/detail?id=4203 TEST=test-ast-expression-visitor, test-typing-reset R=rossberg@chromium.org,titzer@chromium.org LOG=N Committed: https://crrev.com/457fc6bd45e61417c0d7de420b747235077592bd Cr-Commit-Position: refs/heads/master@{#30367}

Patch Set 1 #

Total comments: 4

Patch Set 2 : revised #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -29 lines) Patch
M src/ast-expression-visitor.cc View 1 1 chunk +8 lines, -5 lines 0 comments Download
M test/cctest/test-ast-expression-visitor.cc View 1 3 chunks +79 lines, -12 lines 0 comments Download
M test/cctest/test-typing-reset.cc View 2 chunks +24 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
bradn
5 years, 4 months ago (2015-08-25 07:37:03 UTC) #1
titzer
lgtm
5 years, 4 months ago (2015-08-25 09:54:50 UTC) #2
rossberg
https://codereview.chromium.org/1314843002/diff/1/src/ast-expression-visitor.cc File src/ast-expression-visitor.cc (right): https://codereview.chromium.org/1314843002/diff/1/src/ast-expression-visitor.cc#newcode235 src/ast-expression-visitor.cc:235: void AstExpressionVisitor::VisitYield(Yield* expr) { Shouldn't this change as well? ...
5 years, 4 months ago (2015-08-25 12:29:01 UTC) #3
bradn
ptal https://codereview.chromium.org/1314843002/diff/1/src/ast-expression-visitor.cc File src/ast-expression-visitor.cc (right): https://codereview.chromium.org/1314843002/diff/1/src/ast-expression-visitor.cc#newcode235 src/ast-expression-visitor.cc:235: void AstExpressionVisitor::VisitYield(Yield* expr) { On 2015/08/25 12:29:01, rossberg ...
5 years, 4 months ago (2015-08-25 18:15:04 UTC) #4
rossberg
lgtm
5 years, 4 months ago (2015-08-25 22:20:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314843002/20001
5 years, 4 months ago (2015-08-25 23:40:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-26 01:16:10 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 01:16:25 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/457fc6bd45e61417c0d7de420b747235077592bd
Cr-Commit-Position: refs/heads/master@{#30367}

Powered by Google App Engine
This is Rietveld 408576698