Visit additional AST nodes as expressions in AstExpressionVisitor .

src/ast-expression-visitor.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/ast-expression-visitor.h"
 
 #include "src/ast.h"
 #include "src/codegen.h"
@@ skipping 214 matching lines @@
 }
 
 
 void AstExpressionVisitor::VisitAssignment(Assignment* expr) {
   VisitExpression(expr);
   RECURSE_EXPRESSION(Visit(expr->target()));
   RECURSE_EXPRESSION(Visit(expr->value()));
 }
 
 
 void AstExpressionVisitor::VisitYield(Yield* expr) {

[rossberg, 2015/08/25 12:29:01]

Shouldn't this change as well?

[bradn, 2015/08/25 18:15:04]

Done.

   RECURSE(Visit(expr->generator_object()));
   RECURSE(Visit(expr->expression()));
 }
 
 
 void AstExpressionVisitor::VisitThrow(Throw* expr) {

[rossberg, 2015/08/25 12:29:01]

And this one?

[bradn, 2015/08/25 18:15:04]

Done.

   RECURSE(Visit(expr->exception()));
 }
 
 
 void AstExpressionVisitor::VisitProperty(Property* expr) {
-  RECURSE(Visit(expr->obj()));
-  RECURSE(Visit(expr->key()));
+  VisitExpression(expr);
+  RECURSE_EXPRESSION(Visit(expr->obj()));
+  RECURSE_EXPRESSION(Visit(expr->key()));
 }
 
 
 void AstExpressionVisitor::VisitCall(Call* expr) {
   VisitExpression(expr);
   RECURSE_EXPRESSION(Visit(expr->expression()));
   ZoneList<Expression*>* args = expr->arguments();
   for (int i = 0; i < args->length(); ++i) {
     Expression* arg = args->at(i);
     RECURSE_EXPRESSION(Visit(arg));
@@ skipping 69 matching lines @@
 
 void AstExpressionVisitor::VisitSuperPropertyReference(
     SuperPropertyReference* expr) {}
 
 
 void AstExpressionVisitor::VisitSuperCallReference(SuperCallReference* expr) {}
 }
 
 
 }  // namespace v8::internal