Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1549)

Unified Diff: test/cctest/test-typing-reset.cc

Issue 1314843002: Visit additional AST nodes as expressions in AstExpressionVisitor . (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: revised Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-ast-expression-visitor.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-typing-reset.cc
diff --git a/test/cctest/test-typing-reset.cc b/test/cctest/test-typing-reset.cc
index f92e955d5002c2bdb331c6377121b77ab2d9f4cf..1dc701b55439f33897d8fde65efe70f76f150b82 100644
--- a/test/cctest/test-typing-reset.cc
+++ b/test/cctest/test-typing-reset.cc
@@ -112,10 +112,12 @@ void CheckAllSame(ZoneVector<ExpressionTypeEntry>& types,
CHECK_EXPR(BinaryOperation, expected_type) {
CHECK_EXPR(Call, expected_type) {
CHECK_VAR(log, expected_type);
- CHECK_VAR(values, expected_type);
- CHECK_EXPR(BinaryOperation, expected_type) {
- CHECK_VAR(p, expected_type);
- CHECK_EXPR(Literal, expected_type);
+ CHECK_EXPR(Property, expected_type) {
+ CHECK_VAR(values, expected_type);
+ CHECK_EXPR(BinaryOperation, expected_type) {
+ CHECK_VAR(p, expected_type);
+ CHECK_EXPR(Literal, expected_type);
+ }
}
}
CHECK_EXPR(Literal, expected_type);
@@ -177,23 +179,33 @@ void CheckAllSame(ZoneVector<ExpressionTypeEntry>& types,
// var exp = stdlib.Math.exp;
CHECK_EXPR(Assignment, expected_type) {
CHECK_VAR(exp, expected_type);
- CHECK_VAR(stdlib, expected_type);
- CHECK_EXPR(Literal, expected_type);
- CHECK_EXPR(Literal, expected_type);
+ CHECK_EXPR(Property, expected_type) {
+ CHECK_EXPR(Property, expected_type) {
+ CHECK_VAR(stdlib, expected_type);
+ CHECK_EXPR(Literal, expected_type);
+ }
+ CHECK_EXPR(Literal, expected_type);
+ }
}
// var log = stdlib.Math.log;
CHECK_EXPR(Assignment, expected_type) {
CHECK_VAR(log, expected_type);
- CHECK_VAR(stdlib, expected_type);
- CHECK_EXPR(Literal, expected_type);
- CHECK_EXPR(Literal, expected_type);
+ CHECK_EXPR(Property, expected_type) {
+ CHECK_EXPR(Property, expected_type) {
+ CHECK_VAR(stdlib, expected_type);
+ CHECK_EXPR(Literal, expected_type);
+ }
+ CHECK_EXPR(Literal, expected_type);
+ }
}
// var values = new stdlib.Float64Array(buffer);
CHECK_EXPR(Assignment, expected_type) {
CHECK_VAR(values, expected_type);
CHECK_EXPR(CallNew, expected_type) {
- CHECK_VAR(stdlib, expected_type);
- CHECK_EXPR(Literal, expected_type);
+ CHECK_EXPR(Property, expected_type) {
+ CHECK_VAR(stdlib, expected_type);
+ CHECK_EXPR(Literal, expected_type);
+ }
CHECK_VAR(buffer, expected_type);
}
}
« no previous file with comments | « test/cctest/test-ast-expression-visitor.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698