Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: runtime/vm/log_test.cc

Issue 1314673008: Migrate logging infrastructure Isolate->Thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Finalize marking tasks in parallel, now that it's safe. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/log_test.cc
diff --git a/runtime/vm/log_test.cc b/runtime/vm/log_test.cc
index 370fefc2f81cef9b3fde8c28324214c2dab3ffdd..ba2251ed74876825bd8d405911a0a2c67410c2dc 100644
--- a/runtime/vm/log_test.cc
+++ b/runtime/vm/log_test.cc
@@ -47,8 +47,7 @@ class LogTestHelper : public AllStatic {
TEST_CASE(Log_Macro) {
test_output_ = NULL;
- Isolate* isolate = Isolate::Current();
- Log* log = isolate->Log();
+ Log* log = thread->Log();
LogTestHelper::SetPrinter(log, TestPrinter);
ISL_Print("Hello %s", "World");
@@ -72,15 +71,13 @@ TEST_CASE(Log_Block) {
test_output_ = NULL;
Log* log = new Log(TestPrinter);
- Isolate* isolate = Isolate::Current();
-
EXPECT_EQ(reinterpret_cast<const char*>(NULL), test_output_);
{
- LogBlock ba(isolate, log);
+ LogBlock ba(thread, log);
log->Print("APPLE");
EXPECT_EQ(reinterpret_cast<const char*>(NULL), test_output_);
{
- LogBlock ba(isolate, log);
+ LogBlock ba(thread, log);
log->Print("BANANA");
EXPECT_EQ(reinterpret_cast<const char*>(NULL), test_output_);
}

Powered by Google App Engine
This is Rietveld 408576698