runtime/vm/isolate.h - Issue 1314673008: Migrate logging infrastructure Isolate->Thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.h

Issue 1314673008: Migrate logging infrastructure Isolate->Thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Finalize marking tasks in parallel, now that it's safe. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/isolate.h

diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h

index b8e7a4ca40fa254765ca3b75f3fc121eb9d50362..5ba03987010dfaf7a5eeba42d1dccf2dd3e3ff83 100644

--- a/runtime/vm/isolate.h

+++ b/runtime/vm/isolate.h

@@ -170,8 +170,7 @@ class Isolate : public BaseIsolate {

const char* debugger_name() const { return debugger_name_; }

void set_debugger_name(const char* name);

- // TODO(koda): Move to Thread.

- class Log* Log() const;

+ bool ShouldLog() const;

int64_t start_time() const { return start_time_; }