Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: runtime/vm/isolate.h

Issue 1314673008: Migrate logging infrastructure Isolate->Thread (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Finalize marking tasks in parallel, now that it's safe. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index b8e7a4ca40fa254765ca3b75f3fc121eb9d50362..5ba03987010dfaf7a5eeba42d1dccf2dd3e3ff83 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -170,8 +170,7 @@ class Isolate : public BaseIsolate {
const char* debugger_name() const { return debugger_name_; }
void set_debugger_name(const char* name);
- // TODO(koda): Move to Thread.
- class Log* Log() const;
+ bool ShouldLog() const;
int64_t start_time() const { return start_time_; }
« no previous file with comments | « runtime/vm/il_printer.cc ('k') | runtime/vm/isolate.cc » ('j') | runtime/vm/isolate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698