Issue 13146005: Fix minor cppcheck-found issues

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13146005: Fix minor cppcheck-found issues (Closed)

Created:
7 years, 9 months ago by robertphillips

Modified:
7 years, 8 months ago

Reviewers:
edisonn, bsalomon, reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

These are pesky, minor things (pedantic even, in the case of SkBitSet) so feel free to reject out of hand if you don't like them.

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -4 lines)			Patch
M	src/gpu/GrAAHairLinePathRenderer.cpp	View	2 chunks	+1 line, -1 line	0 comments	Download
M	src/ports/SkFontHost_mac.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/utils/SkBitSet.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/utils/SkBitSet.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

On 2013/03/28 12:29:32, robertphillips wrote: lgtm. The SkBitSet one is perhaps the most legit IMO ...

7 years, 9 months ago (2013-03-28 13:08:04 UTC) #2

reed1

lgtm https://codereview.chromium.org/13146005/diff/1/src/utils/SkBitSet.h File src/utils/SkBitSet.h (right): https://codereview.chromium.org/13146005/diff/1/src/utils/SkBitSet.h#newcode23 src/utils/SkBitSet.h:23: SkBitSet& operator=(const SkBitSet& rhs); that's a funny mistake.

7 years, 9 months ago (2013-03-28 13:34:46 UTC) #3

edisonn

On 2013/03/28 13:34:46, reed1 wrote: > lgtm > > https://codereview.chromium.org/13146005/diff/1/src/utils/SkBitSet.h > File src/utils/SkBitSet.h (right): > ...

7 years, 9 months ago (2013-03-28 14:30:01 UTC) #4

Message was sent while issue was closed.

committed as r8439

Expand Messages | Collapse Messages