Fix minor cppcheck-found issues

src/utils/SkBitSet.h

 
 /*
  * Copyright 2011 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkBitSet_DEFINED
 #define SkBitSet_DEFINED
 
 #include "SkTypes.h"
 #include "SkTDArray.h"
 
 class SkBitSet {
 public:
     /** NumberOfBits must be greater than zero.
      */
     explicit SkBitSet(int numberOfBits);
     explicit SkBitSet(const SkBitSet& source);
 
-    const SkBitSet& operator=(const SkBitSet& rhs);
+    SkBitSet& operator=(const SkBitSet& rhs);

[reed1, 2013/03/28 13:34:46]

that's a funny mistake.

     bool operator==(const SkBitSet& rhs);
     bool operator!=(const SkBitSet& rhs);
 
     /** Clear all data.
      */
     void clearAll();
 
     /** Set the value of the index-th bit.
      */
     void setBit(int index, bool value);
@@ skipping 35 matching lines @@
     uint32_t* internalGet(int index) const {
         SkASSERT((size_t)index < fBitCount);
         size_t internalIndex = index / 32;
         SkASSERT(internalIndex < fDwordCount);
         return reinterpret_cast<uint32_t*>(fBitData.get()) + internalIndex;
     }
 };
 
 
 #endif