chrome/browser/extensions/api/downloads/downloads_api.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/downloads/downloads_api.cc

diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc

index 44e7f29be72b61b35cb723ebf7b3a90f909c5261..6a126aab30ded1d286c8859a36a9034e7fc73412 100644

--- a/chrome/browser/extensions/api/downloads/downloads_api.cc

+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc

@@ -218,9 +218,9 @@ scoped_ptr<base::DictionaryValue> DownloadItemToJSON(

json->SetBoolean(kExistsKey, !download_item->GetFileExternallyRemoved());

json->SetInteger(kIdKey, download_item->GetId());

const GURL& url = download_item->GetOriginalUrl();

- json->SetString(kUrlKey, (url.is_valid() ? url.spec() : ""));

- json->SetString(

- kFilenameKey, download_item->GetFullPath().LossyDisplayName());

+ json->SetString(kUrlKey, (url.is_valid() ? url.spec() : std::string()));

+ json->SetString(kFilenameKey,

+ download_item->GetFullPath().LossyDisplayName());

json->SetString(kDangerKey, DangerString(download_item->GetDangerType()));

if (download_item->GetDangerType() !=

content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS)