chrome/browser/extensions/api/dial/dial_service_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/dial/dial_service_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/dial/dial_service_unittest.cc

diff --git a/chrome/browser/extensions/api/dial/dial_service_unittest.cc b/chrome/browser/extensions/api/dial/dial_service_unittest.cc

index da1cc7b53e03db24a08923deefc191757b7d6d20..b37858965db728e12b9a6444c819fca2f3118fd8 100644

--- a/chrome/browser/extensions/api/dial/dial_service_unittest.cc

+++ b/chrome/browser/extensions/api/dial/dial_service_unittest.cc

@@ -116,9 +116,7 @@ TEST_F(DialServiceTest, TestResponseParsing) {

DialDeviceData not_parsed;

// Empty, garbage

- EXPECT_FALSE(DialServiceImpl::ParseResponse(

- "",

- now, &not_parsed));

+ EXPECT_FALSE(DialServiceImpl::ParseResponse(std::string(), now, &not_parsed));

EXPECT_FALSE(DialServiceImpl::ParseResponse(

"\r\n\r\n",

now, &not_parsed));