Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6304)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api_unittest.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc b/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc
index 23a11317e2fac79aecdb9ed06b50b8e6fbc54592..e403cd5019b23abe79fefbb9182cdfee97aaf901 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api_unittest.cc
@@ -737,7 +737,8 @@ class HTML5FileWriter {
~HTML5FileWriter() {
CHECK(BrowserThread::PostTask(BrowserThread::IO, FROM_HERE, base::Bind(
&HTML5FileWriter::TearDownURLRequestContext, base::Unretained(this))));
- events_listener_->WaitFor(profile_, kURLRequestContextToreDown, "");
+ events_listener_->WaitFor(
+ profile_, kURLRequestContextToreDown, std::string());
}
bool WriteFile() {
@@ -1071,8 +1072,10 @@ IN_PROC_BROWSER_TEST_F(DownloadExtensionTest,
// Simulate an error during icon load by invoking the mock with an empty
// result string.
- std::string error = RunFunctionAndReturnError(MockedGetFileIconFunction(
- download_item->GetTargetFilePath(), IconLoader::NORMAL, ""),
+ std::string error = RunFunctionAndReturnError(
+ MockedGetFileIconFunction(download_item->GetTargetFilePath(),
+ IconLoader::NORMAL,
+ std::string()),
args32);
EXPECT_STREQ(download_extension_errors::kIconNotFoundError, error.c_str());

Powered by Google App Engine
This is Rietveld 408576698