chrome/test/chromedriver/command_executor_impl_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/command_executor_impl_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/command_executor_impl_unittest.cc

diff --git a/chrome/test/chromedriver/command_executor_impl_unittest.cc b/chrome/test/chromedriver/command_executor_impl_unittest.cc

index f538d06f2e0e200e10b0e58d9d37e2570ad337cf..dafa6e42bf09a2a5b83793759915a025502e077d 100644

--- a/chrome/test/chromedriver/command_executor_impl_unittest.cc

+++ b/chrome/test/chromedriver/command_executor_impl_unittest.cc

@@ -118,8 +118,11 @@ TEST(CommandExecutorImplTest, CommandThatReturnsError) {

StatusCode status_code;

scoped_ptr<base::Value> value;

std::string out_session_id;

- executor.ExecuteCommand("simpleCommand", params, "",

- &status_code, &value,

+ executor.ExecuteCommand("simpleCommand",

+ params,

+ std::string(),

+ &status_code,

+ &value,

&out_session_id);

ASSERT_EQ(kUnknownError, status_code);

ASSERT_TRUE(value);