chrome/test/chromedriver/chromedriver_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chromedriver_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/chromedriver_unittest.cc

diff --git a/chrome/test/chromedriver/chromedriver_unittest.cc b/chrome/test/chromedriver/chromedriver_unittest.cc

index 91e1e0613975f0dd99bd4fce8d2b45cbd68d4824..9e585e328b1dc8af561d781852c38415bff6bb0c 100644

--- a/chrome/test/chromedriver/chromedriver_unittest.cc

+++ b/chrome/test/chromedriver/chromedriver_unittest.cc

@@ -164,7 +164,7 @@ TEST(ChromeDriver, ExecuteCommand) {

base::DictionaryValue params;

scoped_ptr<base::Value> value(base::Value::CreateNullValue());

mock->Expect(scoped_ptr<ExpectedCommand>(new ExpectedCommand(

- "quitAll", params, "", kOk, value.Pass(), "")));

+ "quitAll", params, std::string(), kOk, value.Pass(), std::string())));

}

Shutdown();

}