Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index dabe0e2c48ea1863aa68dec4a010e15ebec0a108..dcfc06f2fb3fbcc9ab142a6dd2b68250f202595c 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -28,7 +28,8 @@ TEST(CommandsTest, GetStatus) {
base::DictionaryValue params;
scoped_ptr<base::Value> value;
std::string session_id;
- ASSERT_EQ(kOk, ExecuteGetStatus(params, "", &value, &session_id).code());
+ ASSERT_EQ(
+ kOk, ExecuteGetStatus(params, std::string(), &value, &session_id).code());
base::DictionaryValue* dict;
ASSERT_TRUE(value->GetAsDictionary(&dict));
base::Value* unused;
@@ -72,7 +73,7 @@ TEST(CommandsTest, QuitAll) {
scoped_ptr<base::Value> value;
std::string session_id;
Status status =
- ExecuteQuitAll(cmd, &map, params, "", &value, &session_id);
+ ExecuteQuitAll(cmd, &map, params, std::string(), &value, &session_id);
ASSERT_EQ(kOk, status.code());
ASSERT_FALSE(value.get());
ASSERT_EQ(2, count);
@@ -243,7 +244,7 @@ TEST(CommandsTest, SuccessfulFindElement) {
FindElementWebView web_view(true, kElementExistsQueryTwice);
Session session("id");
session.implicit_wait = 1000;
- session.SwitchToSubFrame("frame_id1", "");
+ session.SwitchToSubFrame("frame_id1", std::string());
base::DictionaryValue params;
params.SetString("using", "id");
params.SetString("value", "a");
@@ -272,7 +273,7 @@ TEST(CommandsTest, SuccessfulFindElements) {
FindElementWebView web_view(false, kElementExistsQueryTwice);
Session session("id");
session.implicit_wait = 1000;
- session.SwitchToSubFrame("frame_id2", "");
+ session.SwitchToSubFrame("frame_id2", std::string());
base::DictionaryValue params;
params.SetString("using", "name");
params.SetString("value", "b");
@@ -306,7 +307,7 @@ TEST(CommandsTest, SuccessfulFindChildElement) {
FindElementWebView web_view(true, kElementExistsQueryTwice);
Session session("id");
session.implicit_wait = 1000;
- session.SwitchToSubFrame("frame_id3", "");
+ session.SwitchToSubFrame("frame_id3", std::string());
base::DictionaryValue params;
params.SetString("using", "tag name");
params.SetString("value", "div");
@@ -344,7 +345,7 @@ TEST(CommandsTest, SuccessfulFindChildElements) {
FindElementWebView web_view(false, kElementExistsQueryTwice);
Session session("id");
session.implicit_wait = 1000;
- session.SwitchToSubFrame("frame_id4", "");
+ session.SwitchToSubFrame("frame_id4", std::string());
base::DictionaryValue params;
params.SetString("using", "class name");
params.SetString("value", "c");
« no previous file with comments | « chrome/test/chromedriver/command_executor_impl_unittest.cc ('k') | chrome/test/chromedriver/key_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698