chrome/browser/extensions/api/dial/dial_service_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/dial/dial_service_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/browser/extensions/api/dial/dial_device_data_unittest.cc ('k') | chrome/browser/extensions/api/downloads/downloads_api.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/memory/ref_counted.h"	5 #include "base/memory/ref_counted.h"

6 #include "base/message_loop.h"	6 #include "base/message_loop.h"

7 #include "chrome/browser/extensions/api/dial/dial_device_data.h"	7 #include "chrome/browser/extensions/api/dial/dial_device_data.h"

8 #include "chrome/browser/extensions/api/dial/dial_service.h"	8 #include "chrome/browser/extensions/api/dial/dial_service.h"

9 #include "net/base/capturing_net_log.h"	9 #include "net/base/capturing_net_log.h"

10 #include "net/base/ip_endpoint.h"	10 #include "net/base/ip_endpoint.h"

(...skipping 98 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
109 now, &parsed));	109 now, &parsed));

110 EXPECT_EQ("some_id", parsed.device_id());	110 EXPECT_EQ("some_id", parsed.device_id());

111 EXPECT_EQ("http://127.0.0.1/dd.xml", parsed.device_description_url().spec());	111 EXPECT_EQ("http://127.0.0.1/dd.xml", parsed.device_description_url().spec());

112 EXPECT_EQ(1, parsed.config_id());	112 EXPECT_EQ(1, parsed.config_id());

113 EXPECT_EQ(now, parsed.response_time());	113 EXPECT_EQ(now, parsed.response_time());

114	114

115 // Failure cases	115 // Failure cases

116 DialDeviceData not_parsed;	116 DialDeviceData not_parsed;

117	117

118 // Empty, garbage	118 // Empty, garbage

119 EXPECT_FALSE(DialServiceImpl::ParseResponse(	119 EXPECT_FALSE(DialServiceImpl::ParseResponse(std::string(), now, &not_parsed));

120 "",

121 now, &not_parsed));

122 EXPECT_FALSE(DialServiceImpl::ParseResponse(	120 EXPECT_FALSE(DialServiceImpl::ParseResponse(

123 "\r\n\r\n",	121 "\r\n\r\n",

124 now, &not_parsed));	122 now, &not_parsed));

125 EXPECT_FALSE(DialServiceImpl::ParseResponse(	123 EXPECT_FALSE(DialServiceImpl::ParseResponse(

126 "xyzzy",	124 "xyzzy",

127 now, &not_parsed));	125 now, &not_parsed));

128	126

129 // No headers	127 // No headers

130 EXPECT_FALSE(DialServiceImpl::ParseResponse(	128 EXPECT_FALSE(DialServiceImpl::ParseResponse(

131 "HTTP/1.1 OK\r\n\r\n",	129 "HTTP/1.1 OK\r\n\r\n",

(...skipping 20 matching lines...) Expand all Loading...
152	150

153 // Empty USN	151 // Empty USN

154 EXPECT_FALSE(DialServiceImpl::ParseResponse(	152 EXPECT_FALSE(DialServiceImpl::ParseResponse(

155 "HTTP/1.1 OK\r\n"	153 "HTTP/1.1 OK\r\n"

156 "LOCATION: http://127.0.0.1/dd.xml\r\n"	154 "LOCATION: http://127.0.0.1/dd.xml\r\n"

157 "USN:\r\n\r\n",	155 "USN:\r\n\r\n",

158 now, &not_parsed));	156 now, &not_parsed));

159 }	157 }

160	158

161 } // namespace extensions	159 } // namespace extensions

OLD	NEW