Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5127)

Unified Diff: chrome/service/cloud_print/printer_job_handler_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/service/cloud_print/printer_job_handler_unittest.cc
diff --git a/chrome/service/cloud_print/printer_job_handler_unittest.cc b/chrome/service/cloud_print/printer_job_handler_unittest.cc
index 9e19519ff7620ee58700ff31930ca2f4497bca2d..0576bb097618536459e4f03d898af3ce5574e6a7 100644
--- a/chrome/service/cloud_print/printer_job_handler_unittest.cc
+++ b/chrome/service/cloud_print/printer_job_handler_unittest.cc
@@ -194,7 +194,7 @@ const char kExamplePrinterDescription[] = "Example Description";
// These are functions used to construct the various sample strings.
std::string JobListResponse(int num_jobs) {
- std::string job_objects = "";
+ std::string job_objects;
for (int i = 0; i < num_jobs; i++) {
job_objects = job_objects + StringPrintf(kExampleJobObject, i+1, i+1, i+1,
i+1);
@@ -683,7 +683,7 @@ TEST_F(PrinterJobHandlerTest, TicketDownloadFailureTest) {
JobListResponse(2), true);
factory_.SetFakeResponse(JobListURI(kJobFetchReasonQueryMore),
JobListResponse(0), true);
- factory_.SetFakeResponse(TicketURI(1), "", false);
+ factory_.SetFakeResponse(TicketURI(1), std::string(), false);
EXPECT_CALL(url_callback_, OnRequestCreate(GURL(TicketURI(1)), _))
.Times(AtLeast(1));
@@ -734,7 +734,7 @@ TEST_F(PrinterJobHandlerTest, DISABLED_ManyFailureTest) {
SetUpJobSuccessTest(1);
- factory_.SetFakeResponse(TicketURI(1), "", false);
+ factory_.SetFakeResponse(TicketURI(1), std::string(), false);
loop_.PostDelayedTask(FROM_HERE,
base::Bind(&net::FakeURLFetcherFactory::SetFakeResponse,
@@ -759,7 +759,7 @@ TEST_F(PrinterJobHandlerTest, DISABLED_CompleteFailureTest) {
factory_.SetFakeResponse(JobListURI(kJobFetchReasonRetry),
JobListResponse(1), true);
factory_.SetFakeResponse(ErrorURI(1), StatusResponse(1, "ERROR"), true);
- factory_.SetFakeResponse(TicketURI(1), "", false);
+ factory_.SetFakeResponse(TicketURI(1), std::string(), false);
EXPECT_CALL(url_callback_,
OnRequestCreate(GURL(JobListURI(kJobFetchReasonStartup)), _))
« no previous file with comments | « chrome/service/cloud_print/connector_settings.cc ('k') | chrome/service/cloud_print/printer_job_queue_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698