chrome/service/cloud_print/printer_job_queue_handler_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/printer_job_queue_handler_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/service/cloud_print/printer_job_queue_handler_unittest.cc

diff --git a/chrome/service/cloud_print/printer_job_queue_handler_unittest.cc b/chrome/service/cloud_print/printer_job_queue_handler_unittest.cc

index 05532b97b9e3e01af6c1580549c13e68db5a9066..b29f5a4271efbaf2779514791a10150f6c6b4e88 100644

--- a/chrome/service/cloud_print/printer_job_queue_handler_unittest.cc

+++ b/chrome/service/cloud_print/printer_job_queue_handler_unittest.cc

@@ -81,7 +81,7 @@ TEST_F(PrinterJobQueueHandlerTest, BasicJobReadTest) {

std::set<std::string> expected_tags;

expected_tags.insert("^own");

- expected_tags.insert("");

+ expected_tags.insert(std::string());

std::set<std::string> actual_tags;

actual_tags.insert(jobs[0].tags_.begin(), jobs[0].tags_.end());