Rewrite std::string("") to std::string(), Linux edition.

chrome/service/cloud_print/printer_job_handler_unittest.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_path.h"
 #include "base/md5.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
 #include "base/message_loop_proxy.h"
@@ skipping 176 matching lines @@
 
 const char kExampleJobDownloadResponseHeaders[] =
     "Content-Type: Application/PDF\n";
 
 const char kExamplePrinterName[] = "Example Printer";
 
 const char kExamplePrinterDescription[] = "Example Description";
 
 // These are functions used to construct the various sample strings.
 std::string JobListResponse(int num_jobs) {
-  std::string job_objects = "";
+  std::string job_objects;
   for (int i = 0; i < num_jobs; i++) {
     job_objects = job_objects + StringPrintf(kExampleJobObject, i+1, i+1, i+1,
                                              i+1);
     if (i != num_jobs-1) job_objects = job_objects + ",";
   }
   return StringPrintf(kExampleJobListResponse, job_objects.c_str());
 }
 
 std::string JobListURI(const char* reason) {
   return StringPrintf(kExamplePrinterJobListURI, reason);
@@ skipping 468 matching lines @@
   BeginTest(20);
 }
 
 TEST_F(PrinterJobHandlerTest, TicketDownloadFailureTest) {
   factory_.SetFakeResponse(JobListURI(kJobFetchReasonStartup),
                            JobListResponse(2), true);
   factory_.SetFakeResponse(JobListURI(kJobFetchReasonFailure),
                            JobListResponse(2), true);
   factory_.SetFakeResponse(JobListURI(kJobFetchReasonQueryMore),
                            JobListResponse(0), true);
-  factory_.SetFakeResponse(TicketURI(1), "", false);
+  factory_.SetFakeResponse(TicketURI(1), std::string(), false);
 
   EXPECT_CALL(url_callback_, OnRequestCreate(GURL(TicketURI(1)), _))
       .Times(AtLeast(1));
 
   EXPECT_CALL(url_callback_,
               OnRequestCreate(GURL(JobListURI(kJobFetchReasonStartup)), _))
       .Times(AtLeast(1));
 
   EXPECT_CALL(url_callback_,
               OnRequestCreate(GURL(JobListURI(kJobFetchReasonQueryMore)), _))
@@ skipping 30 matching lines @@
   EXPECT_CALL(url_callback_,
               OnRequestCreate(GURL(JobListURI(kJobFetchReasonFailure)), _))
       .Times(AtLeast(1));
 
   EXPECT_CALL(url_callback_,
               OnRequestCreate(GURL(JobListURI(kJobFetchReasonRetry)), _))
       .Times(AtLeast(1));
 
   SetUpJobSuccessTest(1);
 
-  factory_.SetFakeResponse(TicketURI(1), "", false);
+  factory_.SetFakeResponse(TicketURI(1), std::string(), false);
 
   loop_.PostDelayedTask(FROM_HERE,
                         base::Bind(&net::FakeURLFetcherFactory::SetFakeResponse,
                                    base::Unretained(&factory_),
                                    TicketURI(1),
                                    kExamplePrintTicket,
                                    true),
                         base::TimeDelta::FromSeconds(1));
 
 
   BeginTest(5);
 }
 
 
 // TODO(noamsml): Figure out how to make this test not take ~64-~2048 (depending
 // constant values) seconds and re-enable it
 TEST_F(PrinterJobHandlerTest, DISABLED_CompleteFailureTest) {
   factory_.SetFakeResponse(JobListURI(kJobFetchReasonStartup),
                            JobListResponse(1), true);
   factory_.SetFakeResponse(JobListURI(kJobFetchReasonFailure),
                            JobListResponse(1), true);
   factory_.SetFakeResponse(JobListURI(kJobFetchReasonRetry),
                            JobListResponse(1), true);
   factory_.SetFakeResponse(ErrorURI(1), StatusResponse(1, "ERROR"), true);
-  factory_.SetFakeResponse(TicketURI(1), "", false);
+  factory_.SetFakeResponse(TicketURI(1), std::string(), false);
 
   EXPECT_CALL(url_callback_,
               OnRequestCreate(GURL(JobListURI(kJobFetchReasonStartup)), _))
       .Times(AtLeast(1));
 
   EXPECT_CALL(url_callback_,
               OnRequestCreate(GURL(JobListURI(kJobFetchReasonFailure)), _))
       .Times(AtLeast(1));
 
   EXPECT_CALL(url_callback_,
               OnRequestCreate(GURL(JobListURI(kJobFetchReasonRetry)), _))
       .Times(AtLeast(1));
 
   EXPECT_CALL(url_callback_, OnRequestCreate(GURL(ErrorURI(1)), _))
       .Times(Exactly(1))
       .WillOnce(InvokeWithoutArgs(
           this, &PrinterJobHandlerTest::MakeJobFetchReturnNoJobs));
 
   EXPECT_CALL(url_callback_, OnRequestCreate(GURL(TicketURI(1)), _))
       .Times(AtLeast(kNumRetriesBeforeAbandonJob));
 
   BeginTest(70);
 }
 
 }  // namespace cloud_print