chrome/browser/extensions/api/declarative/initializing_rules_registry.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cookies/cookies_unittest.cc ('k') | chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

diff --git a/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc b/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

index 0074233b6f5b08036813e33912a3e928cfd54c29..d209beda77529d0950ced6adc5f6038e73abd2c0 100644

--- a/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

+++ b/chrome/browser/extensions/api/declarative/initializing_rules_registry.cc

@@ -39,7 +39,7 @@ std::string InitializingRulesRegistry::RemoveRules(

if (!error.empty())

return error;

RemoveUsedRuleIdentifiers(extension_id, rule_identifiers);

- return "";

+ return std::string();

}

std::string InitializingRulesRegistry::RemoveAllRules(

@@ -48,7 +48,7 @@ std::string InitializingRulesRegistry::RemoveAllRules(

if (!error.empty())

return error;

RemoveAllUsedRuleIdentifiers(extension_id);

- return "";

+ return std::string();

}

std::string InitializingRulesRegistry::GetRules(

@@ -122,7 +122,7 @@ std::string InitializingRulesRegistry::CheckAndFillInOptionalRules(

used_rule_identifiers_[extension_id].insert(*(rule->id));

}

- return "";

+ return std::string();

}

void InitializingRulesRegistry::FillInOptionalPriorities(