chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/declarative/initializing_rules_registry.cc ('k') | chrome/browser/extensions/api/declarative_content/content_condition.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

index 4f49f36ff67660efd7b8f09d87b3b39e681a8123..1be1983c8920261a8e9d65d25791dbd108f4c72e 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc

@@ -69,7 +69,7 @@ TEST_F(RulesRegistryWithCacheTest, AddRules) {

registry_->SetResult("Error");

EXPECT_EQ("Error", AddRule(extension_id, rule_id));

EXPECT_EQ(0, GetNumberOfRules(extension_id));

- registry_->SetResult("");

+ registry_->SetResult(std::string());

// Check that rules can be inserted.

EXPECT_EQ("", AddRule(extension_id, rule_id));

@@ -97,7 +97,7 @@ TEST_F(RulesRegistryWithCacheTest, RemoveRules) {

registry_->SetResult("Error");

EXPECT_EQ("Error", RemoveRule(extension_id, rule_id));

EXPECT_EQ(1, GetNumberOfRules(extension_id));

- registry_->SetResult("");

+ registry_->SetResult(std::string());

// Check that nothing happens if a rule does not exist.

EXPECT_EQ("", RemoveRule(extension_id, "unknown_rule"));

@@ -122,7 +122,7 @@ TEST_F(RulesRegistryWithCacheTest, RemoveAllRules) {

registry_->SetResult("Error");

EXPECT_EQ("Error", registry_->RemoveAllRules(extension_id));

EXPECT_EQ(2, GetNumberOfRules(extension_id));

- registry_->SetResult("");

+ registry_->SetResult(std::string());

// Check that rules may be removed and only for the correct extension.

EXPECT_EQ("", registry_->RemoveAllRules(extension_id));