Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: chrome/browser/extensions/api/cookies/cookies_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/cookies/cookies_unittest.cc
diff --git a/chrome/browser/extensions/api/cookies/cookies_unittest.cc b/chrome/browser/extensions/api/cookies/cookies_unittest.cc
index f1bd93d04078dc649754fe4240a6cb4a3763d2b0..0844b837e223e4fea0c3b60591c719387ed929e1 100644
--- a/chrome/browser/extensions/api/cookies/cookies_unittest.cc
+++ b/chrome/browser/extensions/api/cookies/cookies_unittest.cc
@@ -195,22 +195,36 @@ TEST_F(ExtensionCookiesTest, DomainMatching) {
scoped_ptr<GetAll::Params> params(GetAll::Params::Create(args));
cookies_helpers::MatchFilter filter(&params->details);
- net::CanonicalCookie cookie(GURL(), "", "", tests[i].domain,"",
- base::Time(), base::Time(), base::Time(),
- false, false);
+ net::CanonicalCookie cookie(GURL(),
+ std::string(),
+ std::string(),
+ tests[i].domain,
+ std::string(),
+ base::Time(),
+ base::Time(),
+ base::Time(),
+ false,
+ false);
EXPECT_EQ(tests[i].matches, filter.MatchesCookie(cookie));
}
}
TEST_F(ExtensionCookiesTest, DecodeUTF8WithErrorHandling) {
- net::CanonicalCookie canonical_cookie(
- GURL(), "", "011Q255bNX_1!yd\203e+", "test.com", "/path\203",
- base::Time(), base::Time(), base::Time(), false, false);
+ net::CanonicalCookie canonical_cookie(GURL(),
+ std::string(),
+ "011Q255bNX_1!yd\203e+",
+ "test.com",
+ "/path\203",
+ base::Time(),
+ base::Time(),
+ base::Time(),
+ false,
+ false);
scoped_ptr<Cookie> cookie(
cookies_helpers::CreateCookie(
canonical_cookie, "some cookie store"));
EXPECT_EQ(std::string("011Q255bNX_1!yd\xEF\xBF\xBD" "e+"), cookie->value);
- EXPECT_EQ(std::string(""), cookie->path);
+ EXPECT_EQ(std::string(), cookie->path);
}
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698