Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Unified Diff: net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_util_unittest.cc ('k') | net/base/sdch_filter_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc
diff --git a/net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc b/net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc
index 7ae5da4925153cca5f3dd94ee02851254192b12a..8ad8a55bf0a551466c9c7e5245ecc8d39658f51b 100644
--- a/net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc
+++ b/net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc
@@ -79,7 +79,7 @@ TEST_F(RegistryControlledDomainTest, TestGetDomainAndRegistry) {
EXPECT_EQ("baz.com", GetDomainFromURL("http://baz.com")); // none
EXPECT_EQ("baz.com.", GetDomainFromURL("http://baz.com.")); // none
- EXPECT_EQ("", GetDomainFromURL(""));
+ EXPECT_EQ("", GetDomainFromURL(std::string()));
EXPECT_EQ("", GetDomainFromURL("http://"));
EXPECT_EQ("", GetDomainFromURL("file:///C:/file.html"));
EXPECT_EQ("", GetDomainFromURL("http://foo.com.."));
@@ -108,7 +108,7 @@ TEST_F(RegistryControlledDomainTest, TestGetDomainAndRegistry) {
EXPECT_EQ("baz.com", GetDomainFromHost("baz.com")); // none
EXPECT_EQ("baz.com.", GetDomainFromHost("baz.com.")); // none
- EXPECT_EQ("", GetDomainFromHost(""));
+ EXPECT_EQ("", GetDomainFromHost(std::string()));
EXPECT_EQ("", GetDomainFromHost("foo.com.."));
EXPECT_EQ("", GetDomainFromHost("..."));
EXPECT_EQ("", GetDomainFromHost("192.168.0.1"));
@@ -143,7 +143,7 @@ TEST_F(RegistryControlledDomainTest, TestGetRegistryLength) {
EXPECT_EQ(3U, GetRegistryLengthFromURL("http://baz.com", true)); // none
EXPECT_EQ(4U, GetRegistryLengthFromURL("http://baz.com.", true)); // none
- EXPECT_EQ(std::string::npos, GetRegistryLengthFromURL("", false));
+ EXPECT_EQ(std::string::npos, GetRegistryLengthFromURL(std::string(), false));
EXPECT_EQ(std::string::npos, GetRegistryLengthFromURL("http://", false));
EXPECT_EQ(std::string::npos,
GetRegistryLengthFromURL("file:///C:/file.html", false));
@@ -177,7 +177,7 @@ TEST_F(RegistryControlledDomainTest, TestGetRegistryLength) {
EXPECT_EQ(3U, GetRegistryLengthFromHost("baz.com", true)); // none
EXPECT_EQ(4U, GetRegistryLengthFromHost("baz.com.", true)); // none
- EXPECT_EQ(std::string::npos, GetRegistryLengthFromHost("", false));
+ EXPECT_EQ(std::string::npos, GetRegistryLengthFromHost(std::string(), false));
EXPECT_EQ(0U, GetRegistryLengthFromHost("foo.com..", false));
EXPECT_EQ(0U, GetRegistryLengthFromHost("..", false));
EXPECT_EQ(0U, GetRegistryLengthFromHost("192.168.0.1", false));
« no previous file with comments | « net/base/net_util_unittest.cc ('k') | net/base/sdch_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698