Rewrite std::string("") to std::string(), Linux edition.

net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "googleurl/src/gurl.h"
 #include "net/base/registry_controlled_domains/registry_controlled_domain.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 #include "effective_tld_names_unittest1.cc"
 #undef TOTAL_KEYWORDS
@@ skipping 61 matching lines @@
   EXPECT_EQ("pref.bar.jp", GetDomainFromURL("http://baz.pref.bar.jp"));  // 5
   EXPECT_EQ("b.bar.baz.com.", GetDomainFromURL("http://a.b.bar.baz.com."));
                                                                          // 6
   EXPECT_EQ("a.d.c", GetDomainFromURL("http://a.d.c"));                  // 7
   EXPECT_EQ("a.d.c", GetDomainFromURL("http://.a.d.c"));                 // 7
   EXPECT_EQ("a.d.c", GetDomainFromURL("http://..a.d.c"));                // 7
   EXPECT_EQ("b.c", GetDomainFromURL("http://a.b.c"));                    // 7 8
   EXPECT_EQ("baz.com", GetDomainFromURL("http://baz.com"));              // none
   EXPECT_EQ("baz.com.", GetDomainFromURL("http://baz.com."));            // none
 
-  EXPECT_EQ("", GetDomainFromURL(""));
+  EXPECT_EQ("", GetDomainFromURL(std::string()));
   EXPECT_EQ("", GetDomainFromURL("http://"));
   EXPECT_EQ("", GetDomainFromURL("file:///C:/file.html"));
   EXPECT_EQ("", GetDomainFromURL("http://foo.com.."));
   EXPECT_EQ("", GetDomainFromURL("http://..."));
   EXPECT_EQ("", GetDomainFromURL("http://192.168.0.1"));
   EXPECT_EQ("", GetDomainFromURL("http://localhost"));
   EXPECT_EQ("", GetDomainFromURL("http://localhost."));
   EXPECT_EQ("", GetDomainFromURL("http:////Comment"));
 
   // Test std::string version of GetDomainAndRegistry().  Uses the same
   // underpinnings as the GURL version, so this is really more of a check of
   // CanonicalizeHost().
   EXPECT_EQ("baz.jp", GetDomainFromHost("a.baz.jp"));                  // 1
   EXPECT_EQ("baz.jp.", GetDomainFromHost("a.baz.jp."));                // 1
   EXPECT_EQ("", GetDomainFromHost("ac.jp"));                           // 2
   EXPECT_EQ("", GetDomainFromHost("a.bar.jp"));                        // 3
   EXPECT_EQ("", GetDomainFromHost("bar.jp"));                          // 3
   EXPECT_EQ("", GetDomainFromHost("baz.bar.jp"));                      // 3 4
   EXPECT_EQ("a.b.baz.bar.jp", GetDomainFromHost("a.b.baz.bar.jp"));    // 3 4
   EXPECT_EQ("pref.bar.jp", GetDomainFromHost("baz.pref.bar.jp"));      // 5
   EXPECT_EQ("b.bar.baz.com.", GetDomainFromHost("a.b.bar.baz.com."));  // 6
   EXPECT_EQ("a.d.c", GetDomainFromHost("a.d.c"));                      // 7
   EXPECT_EQ("a.d.c", GetDomainFromHost(".a.d.c"));                     // 7
   EXPECT_EQ("a.d.c", GetDomainFromHost("..a.d.c"));                    // 7
   EXPECT_EQ("b.c", GetDomainFromHost("a.b.c"));                        // 7 8
   EXPECT_EQ("baz.com", GetDomainFromHost("baz.com"));                  // none
   EXPECT_EQ("baz.com.", GetDomainFromHost("baz.com."));                // none
 
-  EXPECT_EQ("", GetDomainFromHost(""));
+  EXPECT_EQ("", GetDomainFromHost(std::string()));
   EXPECT_EQ("", GetDomainFromHost("foo.com.."));
   EXPECT_EQ("", GetDomainFromHost("..."));
   EXPECT_EQ("", GetDomainFromHost("192.168.0.1"));
   EXPECT_EQ("", GetDomainFromHost("localhost."));
   EXPECT_EQ("", GetDomainFromHost(".localhost."));
 }
 
 TEST_F(RegistryControlledDomainTest, TestGetRegistryLength) {
   UseDomainData(Perfect_Hash_Test1::FindDomain);
 
@@ skipping 14 matching lines @@
                                                                         // 6
   EXPECT_EQ(3U, GetRegistryLengthFromURL("http://a.d.c", false));       // 7
   EXPECT_EQ(3U, GetRegistryLengthFromURL("http://.a.d.c", false));      // 7
   EXPECT_EQ(3U, GetRegistryLengthFromURL("http://..a.d.c", false));     // 7
   EXPECT_EQ(1U, GetRegistryLengthFromURL("http://a.b.c", false));       // 7 8
   EXPECT_EQ(0U, GetRegistryLengthFromURL("http://baz.com", false));     // none
   EXPECT_EQ(0U, GetRegistryLengthFromURL("http://baz.com.", false));    // none
   EXPECT_EQ(3U, GetRegistryLengthFromURL("http://baz.com", true));      // none
   EXPECT_EQ(4U, GetRegistryLengthFromURL("http://baz.com.", true));     // none
 
-  EXPECT_EQ(std::string::npos, GetRegistryLengthFromURL("", false));
+  EXPECT_EQ(std::string::npos, GetRegistryLengthFromURL(std::string(), false));
   EXPECT_EQ(std::string::npos, GetRegistryLengthFromURL("http://", false));
   EXPECT_EQ(std::string::npos,
             GetRegistryLengthFromURL("file:///C:/file.html", false));
   EXPECT_EQ(0U, GetRegistryLengthFromURL("http://foo.com..", false));
   EXPECT_EQ(0U, GetRegistryLengthFromURL("http://...", false));
   EXPECT_EQ(0U, GetRegistryLengthFromURL("http://192.168.0.1", false));
   EXPECT_EQ(0U, GetRegistryLengthFromURL("http://localhost", false));
   EXPECT_EQ(0U, GetRegistryLengthFromURL("http://localhost", true));
   EXPECT_EQ(0U, GetRegistryLengthFromURL("http://localhost.", false));
   EXPECT_EQ(0U, GetRegistryLengthFromURL("http://localhost.", true));
@@ skipping 13 matching lines @@
   EXPECT_EQ(11U, GetRegistryLengthFromHost("a.b.bar.baz.com", false));  // 6
   EXPECT_EQ(3U, GetRegistryLengthFromHost("a.d.c", false));             // 7
   EXPECT_EQ(3U, GetRegistryLengthFromHost(".a.d.c", false));            // 7
   EXPECT_EQ(3U, GetRegistryLengthFromHost("..a.d.c", false));           // 7
   EXPECT_EQ(1U, GetRegistryLengthFromHost("a.b.c", false));             // 7 8
   EXPECT_EQ(0U, GetRegistryLengthFromHost("baz.com", false));           // none
   EXPECT_EQ(0U, GetRegistryLengthFromHost("baz.com.", false));          // none
   EXPECT_EQ(3U, GetRegistryLengthFromHost("baz.com", true));            // none
   EXPECT_EQ(4U, GetRegistryLengthFromHost("baz.com.", true));           // none
 
-  EXPECT_EQ(std::string::npos, GetRegistryLengthFromHost("", false));
+  EXPECT_EQ(std::string::npos, GetRegistryLengthFromHost(std::string(), false));
   EXPECT_EQ(0U, GetRegistryLengthFromHost("foo.com..", false));
   EXPECT_EQ(0U, GetRegistryLengthFromHost("..", false));
   EXPECT_EQ(0U, GetRegistryLengthFromHost("192.168.0.1", false));
   EXPECT_EQ(0U, GetRegistryLengthFromHost("localhost", false));
   EXPECT_EQ(0U, GetRegistryLengthFromHost("localhost", true));
   EXPECT_EQ(0U, GetRegistryLengthFromHost("localhost.", false));
   EXPECT_EQ(0U, GetRegistryLengthFromHost("localhost.", true));
 }
 
 TEST_F(RegistryControlledDomainTest, TestSameDomainOrHost) {
@@ skipping 30 matching lines @@
   EXPECT_EQ(3U, GetRegistryLengthFromURL("http://google.com", false));
   EXPECT_EQ(3U, GetRegistryLengthFromURL("http://stanford.edu", false));
   EXPECT_EQ(3U, GetRegistryLengthFromURL("http://ustreas.gov", false));
   EXPECT_EQ(3U, GetRegistryLengthFromURL("http://icann.net", false));
   EXPECT_EQ(3U, GetRegistryLengthFromURL("http://ferretcentral.org", false));
   EXPECT_EQ(0U, GetRegistryLengthFromURL("http://nowhere.foo", false));
   EXPECT_EQ(3U, GetRegistryLengthFromURL("http://nowhere.foo", true));
 }
 
 }  // namespace net