net/base/sdch_filter_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/sdch_filter_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/sdch_filter_unittest.cc

diff --git a/net/base/sdch_filter_unittest.cc b/net/base/sdch_filter_unittest.cc

index 2e0f5ec75ae3a7e98eae44fd172a41856e09f1e6..1cc70cb58be4b4df9929ff1381e2c6ed94328003 100644

--- a/net/base/sdch_filter_unittest.cc

+++ b/net/base/sdch_filter_unittest.cc

@@ -1346,7 +1346,7 @@ TEST_F(SdchFilterTest, PathMatch) {

// Make sure less that sufficient prefix match is false.

EXPECT_FALSE(PathMatch("/sear", "/search"));

EXPECT_FALSE(PathMatch("/", "/search"));

- EXPECT_FALSE(PathMatch("", "/search"));

+ EXPECT_FALSE(PathMatch(std::string(), "/search"));

// Add examples with several levels of direcories in the restriction.

EXPECT_FALSE(PathMatch("/search/something", "search/s"));