chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc ('k') | chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc b/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc

index 8c29d07ddc075954015be4f96d386fcf70cad185..019a45b6a7f640b327442a695687e6edd15fa47a 100644

--- a/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc

+++ b/chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc

@@ -104,9 +104,9 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataDatabaseHelperTest, CannedAddDatabase) {

scoped_refptr<CannedBrowsingDataDatabaseHelper> helper(

new CannedBrowsingDataDatabaseHelper(browser()->profile()));

- helper->AddDatabase(origin1, db1, "");

- helper->AddDatabase(origin1, db2, "");

- helper->AddDatabase(origin2, db3, "");

+ helper->AddDatabase(origin1, db1, std::string());

+ helper->AddDatabase(origin1, db2, std::string());

+ helper->AddDatabase(origin2, db3, std::string());

TestCompletionCallback callback;

helper->StartFetching(

@@ -136,8 +136,8 @@ IN_PROC_BROWSER_TEST_F(BrowsingDataDatabaseHelperTest, CannedUnique) {

scoped_refptr<CannedBrowsingDataDatabaseHelper> helper(

new CannedBrowsingDataDatabaseHelper(browser()->profile()));

- helper->AddDatabase(origin, db, "");

+ helper->AddDatabase(origin, db, std::string());

TestCompletionCallback callback;

helper->StartFetching(