chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bookmarks/bookmark_utils_unittest.cc ('k') | chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc

index 94df56c6ec7483508ad929ab028b2475e6cf38d0..be0879bd6722120d1727211fb008c97567934f59 100644

--- a/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc

+++ b/chrome/browser/browsing_data/browsing_data_cookie_helper_unittest.cc

@@ -277,8 +277,10 @@ TEST_F(BrowsingDataCookieHelperTest, CannedDomainCookie) {

helper->AddChangedCookie(origin, origin, "A=1; Domain=.www.google.com",

net::CookieOptions());

// Try adding invalid cookies that will be ignored.

- helper->AddChangedCookie(origin, origin, "", net::CookieOptions());

- helper->AddChangedCookie(origin, origin, "C=bad guy; Domain=wrongdomain.com",

+ helper->AddChangedCookie(origin, origin, std::string(), net::CookieOptions());

+ helper->AddChangedCookie(origin,

+ origin,

+ "C=bad guy; Domain=wrongdomain.com",

net::CookieOptions());

helper->StartFetching(