chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_database_helper_browsertest.cc ('k') | chrome/browser/browsing_data/cookies_tree_model_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc b/chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc

index 2a2b47483d686215613fa87b3af64a977f7a1904..89c290de01a923046b48b2f4bf1fef2ffa6d4d48 100644

--- a/chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc

+++ b/chrome/browser/browsing_data/browsing_data_database_helper_unittest.cc

@@ -35,7 +35,7 @@ TEST_F(CannedBrowsingDataDatabaseHelperTest, Empty) {

new CannedBrowsingDataDatabaseHelper(&profile));

ASSERT_TRUE(helper->empty());

- helper->AddDatabase(origin, db, "");

+ helper->AddDatabase(origin, db, std::string());

ASSERT_FALSE(helper->empty());

helper->Reset();

ASSERT_TRUE(helper->empty());

@@ -52,9 +52,9 @@ TEST_F(CannedBrowsingDataDatabaseHelperTest, IgnoreExtensionsAndDevTools) {

new CannedBrowsingDataDatabaseHelper(&profile));

ASSERT_TRUE(helper->empty());

- helper->AddDatabase(origin1, db, "");

+ helper->AddDatabase(origin1, db, std::string());

ASSERT_TRUE(helper->empty());

- helper->AddDatabase(origin2, db, "");

+ helper->AddDatabase(origin2, db, std::string());

ASSERT_TRUE(helper->empty());

helper->Reset();

ASSERT_TRUE(helper->empty());