Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1146)

Unified Diff: chrome/browser/history/history_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_tab_helper.cc ('k') | chrome/browser/history/thumbnail_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_unittest.cc
diff --git a/chrome/browser/history/history_unittest.cc b/chrome/browser/history/history_unittest.cc
index e465a806eb7f01124e4b65c54eb97e63566925db..c988e55cb08db3910a73ea7afc78400f01644da7 100644
--- a/chrome/browser/history/history_unittest.cc
+++ b/chrome/browser/history/history_unittest.cc
@@ -164,20 +164,19 @@ class HistoryBackendDBTest : public HistoryUnitTestBase {
std::vector<GURL> url_chain;
url_chain.push_back(GURL("foo-url"));
- DownloadRow download(
- base::FilePath(FILE_PATH_LITERAL("foo-path")),
- base::FilePath(FILE_PATH_LITERAL("foo-path")),
- url_chain,
- GURL(""),
- time,
- time,
- 0,
- 512,
- state,
- content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
- content::DOWNLOAD_INTERRUPT_REASON_NONE,
- 0,
- 0);
+ DownloadRow download(base::FilePath(FILE_PATH_LITERAL("foo-path")),
+ base::FilePath(FILE_PATH_LITERAL("foo-path")),
+ url_chain,
+ GURL(std::string()),
+ time,
+ time,
+ 0,
+ 512,
+ state,
+ content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
+ content::DOWNLOAD_INTERRUPT_REASON_NONE,
+ 0,
+ 0);
return db_->CreateDownload(download);
}
@@ -317,7 +316,7 @@ TEST_F(HistoryBackendDBTest, MigrateDownloadsReasonPathsAndDangerType) {
int64 db_handle = 0;
// Null path.
s.BindInt64(0, ++db_handle);
- s.BindString(1, "");
+ s.BindString(1, std::string());
s.BindString(2, "http://whatever.com/index.html");
s.BindInt64(3, now.ToTimeT());
s.BindInt64(4, 100);
@@ -464,20 +463,19 @@ TEST_F(HistoryBackendDBTest, DownloadNukeRecordsMissingURLs) {
CreateBackendAndDatabase();
base::Time now(base::Time::Now());
std::vector<GURL> url_chain;
- DownloadRow download(
- base::FilePath(FILE_PATH_LITERAL("foo-path")),
- base::FilePath(FILE_PATH_LITERAL("foo-path")),
- url_chain,
- GURL(""),
- now,
- now,
- 0,
- 512,
- DownloadItem::COMPLETE,
- content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
- content::DOWNLOAD_INTERRUPT_REASON_NONE,
- 0,
- 0);
+ DownloadRow download(base::FilePath(FILE_PATH_LITERAL("foo-path")),
+ base::FilePath(FILE_PATH_LITERAL("foo-path")),
+ url_chain,
+ GURL(std::string()),
+ now,
+ now,
+ 0,
+ 512,
+ DownloadItem::COMPLETE,
+ content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
+ content::DOWNLOAD_INTERRUPT_REASON_NONE,
+ 0,
+ 0);
// Creating records without any urls should fail.
EXPECT_EQ(DownloadDatabase::kUninitializedHandle,
« no previous file with comments | « chrome/browser/history/history_tab_helper.cc ('k') | chrome/browser/history/thumbnail_database_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698