Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2115)

Unified Diff: chrome/browser/history/thumbnail_database_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_unittest.cc ('k') | chrome/browser/importer/firefox_importer_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/thumbnail_database_unittest.cc
diff --git a/chrome/browser/history/thumbnail_database_unittest.cc b/chrome/browser/history/thumbnail_database_unittest.cc
index fc92febaab1e711dab241e27deace55a98ea8c3c..de3bd330d6b4202ee03a6aaf18c3db8cf2dc17b8 100644
--- a/chrome/browser/history/thumbnail_database_unittest.cc
+++ b/chrome/browser/history/thumbnail_database_unittest.cc
@@ -414,7 +414,7 @@ TEST_F(ThumbnailDatabaseTest, UpgradeToVersion6) {
EXPECT_EQ(url, GURL(statement.ColumnString(1)));
EXPECT_EQ(TOUCH_ICON, statement.ColumnInt(2));
// Any previous data in sizes should be cleared.
- EXPECT_EQ(std::string(""), statement.ColumnString(3));
+ EXPECT_EQ(std::string(), statement.ColumnString(3));
statement.Assign(db.db_.GetCachedStatement(SQL_FROM_HERE,
"SELECT icon_id, last_updated, image_data, width, height "
@@ -854,7 +854,7 @@ TEST_F(ThumbnailDatabaseTest, FaviconSizesToAndFromString) {
// Valid input.
FaviconSizes sizes_empty;
- ThumbnailDatabase::DatabaseStringToFaviconSizes("", &sizes_empty);
+ ThumbnailDatabase::DatabaseStringToFaviconSizes(std::string(), &sizes_empty);
EXPECT_EQ(0u, sizes_empty.size());
FaviconSizes sizes_valid;
« no previous file with comments | « chrome/browser/history/history_unittest.cc ('k') | chrome/browser/importer/firefox_importer_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698