Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/history/history_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // History unit tests come in two flavors:
 //
 // 1. The more complicated style is that the unit test creates a full history
 //    service. This spawns a background thread for the history backend, and
 //    all communication is asynchronous. This is useful for testing more
 //    complicated things or end-to-end behavior.
@@ skipping 146 matching lines @@
     // Make sure we don't have any event pending that could disrupt the next
     // test.
     MessageLoop::current()->PostTask(FROM_HERE, MessageLoop::QuitClosure());
     MessageLoop::current()->Run();
   }
 
   int64 AddDownload(DownloadItem::DownloadState state, const Time& time) {
     std::vector<GURL> url_chain;
     url_chain.push_back(GURL("foo-url"));
 
-    DownloadRow download(
-        base::FilePath(FILE_PATH_LITERAL("foo-path")),
-        base::FilePath(FILE_PATH_LITERAL("foo-path")),
-        url_chain,
-        GURL(""),
-        time,
-        time,
-        0,
-        512,
-        state,
-        content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
-        content::DOWNLOAD_INTERRUPT_REASON_NONE,
-        0,
-        0);
+    DownloadRow download(base::FilePath(FILE_PATH_LITERAL("foo-path")),
+                         base::FilePath(FILE_PATH_LITERAL("foo-path")),
+                         url_chain,
+                         GURL(std::string()),
+                         time,
+                         time,
+                         0,
+                         512,
+                         state,
+                         content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
+                         content::DOWNLOAD_INTERRUPT_REASON_NONE,
+                         0,
+                         0);
     return db_->CreateDownload(download);
   }
 
   base::ScopedTempDir temp_dir_;
 
   MessageLoopForUI message_loop_;
 
   // names of the database files
   base::FilePath history_dir_;
 
@@ skipping 119 matching lines @@
 
     // Manually insert some rows.
     sql::Statement s(db.GetUniqueStatement(
         "INSERT INTO downloads (id, full_path, url, start_time, "
         "received_bytes, total_bytes, state, end_time, opened) VALUES "
         "(?, ?, ?, ?, ?, ?, ?, ?, ?)"));
 
     int64 db_handle = 0;
     // Null path.
     s.BindInt64(0, ++db_handle);
-    s.BindString(1, "");
+    s.BindString(1, std::string());
     s.BindString(2, "http://whatever.com/index.html");
     s.BindInt64(3, now.ToTimeT());
     s.BindInt64(4, 100);
     s.BindInt64(5, 100);
     s.BindInt(6, 1);
     s.BindInt64(7, now.ToTimeT());
     s.BindInt(8, 1);
     ASSERT_TRUE(s.Run());
     s.Reset(true);
 
@@ skipping 126 matching lines @@
         "Select Count(*) from downloads_url_chains"));
     EXPECT_TRUE(statement1.Step());
     EXPECT_EQ(1, statement1.ColumnInt(0));
   }
 }
 
 TEST_F(HistoryBackendDBTest, DownloadNukeRecordsMissingURLs) {
   CreateBackendAndDatabase();
   base::Time now(base::Time::Now());
   std::vector<GURL> url_chain;
-  DownloadRow download(
-      base::FilePath(FILE_PATH_LITERAL("foo-path")),
-      base::FilePath(FILE_PATH_LITERAL("foo-path")),
-      url_chain,
-      GURL(""),
-      now,
-      now,
-      0,
-      512,
-      DownloadItem::COMPLETE,
-      content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
-      content::DOWNLOAD_INTERRUPT_REASON_NONE,
-      0,
-      0);
+  DownloadRow download(base::FilePath(FILE_PATH_LITERAL("foo-path")),
+                       base::FilePath(FILE_PATH_LITERAL("foo-path")),
+                       url_chain,
+                       GURL(std::string()),
+                       now,
+                       now,
+                       0,
+                       512,
+                       DownloadItem::COMPLETE,
+                       content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
+                       content::DOWNLOAD_INTERRUPT_REASON_NONE,
+                       0,
+                       0);
 
   // Creating records without any urls should fail.
   EXPECT_EQ(DownloadDatabase::kUninitializedHandle,
             db_->CreateDownload(download));
 
   download.url_chain.push_back(GURL("foo-url"));
   EXPECT_EQ(1, db_->CreateDownload(download));
 
   // Pretend that the URLs were dropped.
   DeleteBackend();
@@ skipping 1195 matching lines @@
   std::vector<PageUsageData*> results;
   db_->QuerySegmentUsage(segment_time, 10, &results);
   ASSERT_EQ(1u, results.size());
   EXPECT_EQ(url, results[0]->GetURL());
   EXPECT_EQ(segment_id, results[0]->GetID());
   EXPECT_EQ(title, results[0]->GetTitle());
   STLDeleteElements(&results);
 }
 
 }  // namespace history