Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2050)

Unified Diff: chrome/browser/bookmarks/bookmark_utils_unittest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/bookmarks/bookmark_utils_unittest.cc
diff --git a/chrome/browser/bookmarks/bookmark_utils_unittest.cc b/chrome/browser/bookmarks/bookmark_utils_unittest.cc
index f71645e2a8c316c63efe0970d6e9d5ff7f626a46..a5f253d94223b578a47cbfc4e0a763dc1c3f3695 100644
--- a/chrome/browser/bookmarks/bookmark_utils_unittest.cc
+++ b/chrome/browser/bookmarks/bookmark_utils_unittest.cc
@@ -166,22 +166,31 @@ TEST_F(BookmarkUtilsTest, ApplyEditsWithNoFolderChange) {
{
BookmarkEditor::EditDetails detail(
BookmarkEditor::EditDetails::AddFolder(bookmarkbar, 1));
- ApplyEditsWithNoFolderChange(&model, bookmarkbar, detail,
- ASCIIToUTF16("folder0"), GURL(""));
+ ApplyEditsWithNoFolderChange(&model,
+ bookmarkbar,
+ detail,
+ ASCIIToUTF16("folder0"),
+ GURL(std::string()));
EXPECT_EQ(ASCIIToUTF16("folder0"), bookmarkbar->GetChild(1)->GetTitle());
}
{
BookmarkEditor::EditDetails detail(
BookmarkEditor::EditDetails::AddFolder(bookmarkbar, -1));
- ApplyEditsWithNoFolderChange(&model, bookmarkbar, detail,
- ASCIIToUTF16("folder1"), GURL(""));
+ ApplyEditsWithNoFolderChange(&model,
+ bookmarkbar,
+ detail,
+ ASCIIToUTF16("folder1"),
+ GURL(std::string()));
EXPECT_EQ(ASCIIToUTF16("folder1"), bookmarkbar->GetChild(3)->GetTitle());
}
{
BookmarkEditor::EditDetails detail(
BookmarkEditor::EditDetails::AddFolder(bookmarkbar, 10));
- ApplyEditsWithNoFolderChange(&model, bookmarkbar, detail,
- ASCIIToUTF16("folder2"), GURL(""));
+ ApplyEditsWithNoFolderChange(&model,
+ bookmarkbar,
+ detail,
+ ASCIIToUTF16("folder2"),
+ GURL(std::string()));
EXPECT_EQ(ASCIIToUTF16("folder2"), bookmarkbar->GetChild(4)->GetTitle());
}
}

Powered by Google App Engine
This is Rietveld 408576698