Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5262)

Unified Diff: chrome/browser/signin/signin_manager.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/signin_internals_util.cc ('k') | chrome/browser/signin/signin_manager_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_manager.cc
diff --git a/chrome/browser/signin/signin_manager.cc b/chrome/browser/signin/signin_manager.cc
index a8bc0819236676b11e3c04a912e79461d105ce5e..ab5befceaf7cc13a60fe5713db117fe4a5879f3c 100644
--- a/chrome/browser/signin/signin_manager.cc
+++ b/chrome/browser/signin/signin_manager.cc
@@ -305,10 +305,9 @@ std::string SigninManager::SigninTypeToString(
}
NOTREACHED();
- return "";
+ return std::string();
}
-
bool SigninManager::PrepareForSignin(SigninType type,
const std::string& username,
const std::string& password) {
@@ -468,7 +467,8 @@ void SigninManager::StartSignInWithOAuth(const std::string& username,
scopes.push_back(GaiaUrls::GetInstance()->oauth1_login_scope());
const std::string& locale = g_browser_process->GetApplicationLocale();
- client_login_->StartClientOAuth(username, password, scopes, "", locale);
+ client_login_->StartClientOAuth(
+ username, password, scopes, std::string(), locale);
// Register for token availability. The signin manager will pre-login the
// user when the GAIA service token is ready for use. Only do this if we
@@ -549,10 +549,9 @@ void SigninManager::SignOut() {
profile_->GetPrefs()->ClearPref(prefs::kGoogleServicesUsername);
// Erase (now) stale information from AboutSigninInternals.
- NotifyDiagnosticsObservers(USERNAME, "");
- NotifyDiagnosticsObservers(LSID, "");
- NotifyDiagnosticsObservers(
- signin_internals_util::SID, "");
+ NotifyDiagnosticsObservers(USERNAME, std::string());
+ NotifyDiagnosticsObservers(LSID, std::string());
+ NotifyDiagnosticsObservers(signin_internals_util::SID, std::string());
TokenService* token_service = TokenServiceFactory::GetForProfile(profile_);
content::NotificationService::current()->Notify(
« no previous file with comments | « chrome/browser/signin/signin_internals_util.cc ('k') | chrome/browser/signin/signin_manager_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698