Rewrite std::string("") to std::string(), Linux edition.

chrome/browser/signin/signin_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/signin_manager.h"
 
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 287 matching lines @@
       return "No Signin";
     case SIGNIN_TYPE_CLIENT_LOGIN:
       return "Client Login";
     case SIGNIN_TYPE_WITH_CREDENTIALS:
       return "Signin with credentials";
     case SIGNIN_TYPE_CLIENT_OAUTH:
       return "Client OAuth";
   }
 
   NOTREACHED();
-  return "";
+  return std::string();
 }
 
-
 bool SigninManager::PrepareForSignin(SigninType type,
                                      const std::string& username,
                                      const std::string& password) {
   DCHECK(possibly_invalid_username_.empty() ||
          possibly_invalid_username_ == username);
   DCHECK(!username.empty());
 
   if (!IsAllowedUsername(username)) {
     // Account is not allowed by admin policy.
     HandleAuthError(GoogleServiceAuthError(
@@ skipping 139 matching lines @@
                                          const std::string& password) {
   DCHECK(authenticated_username_.empty());
 
   if (!PrepareForSignin(SIGNIN_TYPE_CLIENT_OAUTH, username, password))
     return;
 
   std::vector<std::string> scopes;
   scopes.push_back(GaiaUrls::GetInstance()->oauth1_login_scope());
   const std::string& locale = g_browser_process->GetApplicationLocale();
 
-  client_login_->StartClientOAuth(username, password, scopes, "", locale);
+  client_login_->StartClientOAuth(
+      username, password, scopes, std::string(), locale);
 
   // Register for token availability.  The signin manager will pre-login the
   // user when the GAIA service token is ready for use.  Only do this if we
   // are not running in ChomiumOS, since it handles pre-login itself, and if
   // cookies are not disabled for Google accounts.
 #if !defined(OS_CHROMEOS)
   if (AreSigninCookiesAllowed(profile_)) {
     TokenService* token_service = TokenServiceFactory::GetForProfile(profile_);
     registrar_.Add(this,
                    chrome::NOTIFICATION_TOKEN_AVAILABLE,
@@ skipping 60 matching lines @@
     return;
   }
 
   GoogleServiceSignoutDetails details(authenticated_username_);
 
   ClearTransientSigninData();
   authenticated_username_.clear();
   profile_->GetPrefs()->ClearPref(prefs::kGoogleServicesUsername);
 
   // Erase (now) stale information from AboutSigninInternals.
-  NotifyDiagnosticsObservers(USERNAME, "");
-  NotifyDiagnosticsObservers(LSID, "");
-  NotifyDiagnosticsObservers(
-      signin_internals_util::SID, "");
+  NotifyDiagnosticsObservers(USERNAME, std::string());
+  NotifyDiagnosticsObservers(LSID, std::string());
+  NotifyDiagnosticsObservers(signin_internals_util::SID, std::string());
 
   TokenService* token_service = TokenServiceFactory::GetForProfile(profile_);
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_GOOGLE_SIGNED_OUT,
       content::Source<Profile>(profile_),
       content::Details<const GoogleServiceSignoutDetails>(&details));
   RevokeOAuthLoginToken();
   token_service->ResetCredentialsInMemory();
   token_service->EraseTokensFromDB();
 }
@@ skipping 388 matching lines @@
                     NotifySigninValueChanged(field, value));
 }
 
 void SigninManager::NotifyDiagnosticsObservers(
     const TimedSigninStatusField& field,
     const std::string& value) {
   FOR_EACH_OBSERVER(SigninDiagnosticsObserver,
                     signin_diagnostics_observers_,
                     NotifySigninValueChanged(field, value));
 }