Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6255)

Unified Diff: chrome/browser/signin/signin_internals_util.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/signin/oauth2_token_service_unittest.cc ('k') | chrome/browser/signin/signin_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/signin_internals_util.cc
diff --git a/chrome/browser/signin/signin_internals_util.cc b/chrome/browser/signin/signin_internals_util.cc
index adae0a1e42dbd3a89b3940ca631d582c2fdcbe44..f18741866d3cf591ba78ff7a15f45d91415337be 100644
--- a/chrome/browser/signin/signin_internals_util.cc
+++ b/chrome/browser/signin/signin_internals_util.cc
@@ -98,11 +98,11 @@ std::string SigninStatusFieldToString(UntimedSigninStatusField field) {
ENUM_CASE(LSID);
case UNTIMED_FIELDS_END:
NOTREACHED();
- return "";
+ return std::string();
}
NOTREACHED();
- return "";
+ return std::string();
}
std::string SigninStatusFieldToString(TimedSigninStatusField field) {
@@ -113,11 +113,11 @@ std::string SigninStatusFieldToString(TimedSigninStatusField field) {
ENUM_CASE(GET_USER_INFO_STATUS);
case TIMED_FIELDS_END:
NOTREACHED();
- return "";
+ return std::string();
}
NOTREACHED();
- return "";
+ return std::string();
}
SigninStatus::SigninStatus()
@@ -203,10 +203,10 @@ std::string SigninStatusFieldToLabel(UntimedSigninStatusField field) {
return "Sid (Hash)";
case UNTIMED_FIELDS_END:
NOTREACHED();
- return "";
+ return std::string();
}
NOTREACHED();
- return "";
+ return std::string();
}
TimedSigninStatusValue SigninStatusFieldToLabel(
@@ -226,10 +226,10 @@ TimedSigninStatusValue SigninStatusFieldToLabel(
"Last OnGetUserInfo Time");
case TIMED_FIELDS_END:
NOTREACHED();
- return TimedSigninStatusValue("Error", "");
+ return TimedSigninStatusValue("Error", std::string());
}
NOTREACHED();
- return TimedSigninStatusValue("Error", "");
+ return TimedSigninStatusValue("Error", std::string());
}
} // namespace
« no previous file with comments | « chrome/browser/signin/oauth2_token_service_unittest.cc ('k') | chrome/browser/signin/signin_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698