chrome/browser/extensions/api/identity/identity_apitest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/identity/identity_apitest.cc

diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc

index b6fec79dab92e89b703c2f0408457ae89ff8388a..174f92250474aede58239dd8fd35b578bcf5666f 100644

--- a/chrome/browser/extensions/api/identity/identity_apitest.cc

+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc

@@ -508,7 +508,7 @@ class LaunchWebAuthFlowFunctionTest : public ExtensionBrowserTest {

};

IN_PROC_BROWSER_TEST_F(LaunchWebAuthFlowFunctionTest, Bounds) {

- RunAndCheckBounds("", 0, 0, 0, 0);

+ RunAndCheckBounds(std::string(), 0, 0, 0, 0);

RunAndCheckBounds("\"width\": 100, \"height\": 200", 0, 0, 100, 200);

RunAndCheckBounds("\"left\": 100, \"top\": 200", 100, 200, 0, 0);

RunAndCheckBounds(