Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Side by Side Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Ugh Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/string_util.h" 5 #include "base/string_util.h"
6 #include "base/stringprintf.h" 6 #include "base/stringprintf.h"
7 #include "base/values.h" 7 #include "base/values.h"
8 #include "chrome/browser/extensions/api/identity/identity_api.h" 8 #include "chrome/browser/extensions/api/identity/identity_api.h"
9 #include "chrome/browser/extensions/api/identity/web_auth_flow.h" 9 #include "chrome/browser/extensions/api/identity/web_auth_flow.h"
10 #include "chrome/browser/extensions/extension_apitest.h" 10 #include "chrome/browser/extensions/extension_apitest.h"
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
501 EXPECT_EQ(expected_y, web_auth_flow_browser->override_bounds().y()); 501 EXPECT_EQ(expected_y, web_auth_flow_browser->override_bounds().y());
502 EXPECT_EQ(expected_width, web_auth_flow_browser->override_bounds().width()); 502 EXPECT_EQ(expected_width, web_auth_flow_browser->override_bounds().width());
503 EXPECT_EQ( 503 EXPECT_EQ(
504 expected_height, web_auth_flow_browser->override_bounds().height()); 504 expected_height, web_auth_flow_browser->override_bounds().height());
505 505
506 web_auth_flow_browser->window()->Close(); 506 web_auth_flow_browser->window()->Close();
507 } 507 }
508 }; 508 };
509 509
510 IN_PROC_BROWSER_TEST_F(LaunchWebAuthFlowFunctionTest, Bounds) { 510 IN_PROC_BROWSER_TEST_F(LaunchWebAuthFlowFunctionTest, Bounds) {
511 RunAndCheckBounds("", 0, 0, 0, 0); 511 RunAndCheckBounds(std::string(), 0, 0, 0, 0);
512 RunAndCheckBounds("\"width\": 100, \"height\": 200", 0, 0, 100, 200); 512 RunAndCheckBounds("\"width\": 100, \"height\": 200", 0, 0, 100, 200);
513 RunAndCheckBounds("\"left\": 100, \"top\": 200", 100, 200, 0, 0); 513 RunAndCheckBounds("\"left\": 100, \"top\": 200", 100, 200, 0, 0);
514 RunAndCheckBounds( 514 RunAndCheckBounds(
515 "\"left\": 100, \"top\": 200, \"width\": 300, \"height\": 400", 515 "\"left\": 100, \"top\": 200, \"width\": 300, \"height\": 400",
516 100, 200, 300, 400); 516 100, 200, 300, 400);
517 } 517 }
518 518
519 } // namespace extensions 519 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698