chrome/browser/extensions/api/management/management_api_browsertest.cc - Issue 13145003: Rewrite std::string("") to std::string(), Linux edition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api_browsertest.cc

Issue 13145003: Rewrite std::string("") to std::string(), Linux edition. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Ugh Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/identity/identity_apitest.cc ('k') | chrome/browser/extensions/api/messaging/message_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/management/management_api_browsertest.cc b/chrome/browser/extensions/api/management/management_api_browsertest.cc

index f475e8111edd0fe2f503b0b4302ebbb696a57e6c..5b6b04d45995ffc02fcd20e5623fcd0ea93e4700 100644

--- a/chrome/browser/extensions/api/management/management_api_browsertest.cc

+++ b/chrome/browser/extensions/api/management/management_api_browsertest.cc

@@ -257,15 +257,15 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementApiEscalationTest,

// This should succeed when user accepts dialog.

CommandLine::ForCurrentProcess()->AppendSwitchASCII(

switches::kAppsGalleryInstallAutoConfirmForTests, "accept");

- SetEnabled(true, true, "");

+ SetEnabled(true, true, std::string());

// Crash the extension. Mock a reload by disabling and then enabling. The

// extension should be reloaded and enabled.

ASSERT_TRUE(CrashEnabledExtension(kId));

- SetEnabled(false, true, "");

- SetEnabled(true, true, "");

- const Extension* extension = ExtensionSystem::Get(browser()->profile())->

- extension_service()->GetExtensionById(kId, false);

+ SetEnabled(false, true, std::string());

+ SetEnabled(true, true, std::string());

+ const Extension* extension = ExtensionSystem::Get(browser()->profile())

+ ->extension_service()->GetExtensionById(kId, false);

EXPECT_TRUE(extension);

}